From 5131897997c4eb547afa6a722d648b5145045627 Mon Sep 17 00:00:00 2001 From: Josh Date: Wed, 24 Sep 2025 11:18:07 -0400 Subject: [PATCH 1/2] fix(workflowenigne): stricter length headler handling Fixes #55276 and tidies things up a bit more for future maintenance. Signed-off-by: Josh --- apps/workflowengine/lib/Check/FileSize.php | 23 +++++++++++++++++----- 1 file changed, 18 insertions(+), 5 deletions(-) diff --git a/apps/workflowengine/lib/Check/FileSize.php b/apps/workflowengine/lib/Check/FileSize.php index 7d3d4e4782769..6337f004a0631 100644 --- a/apps/workflowengine/lib/Check/FileSize.php +++ b/apps/workflowengine/lib/Check/FileSize.php @@ -57,23 +57,36 @@ public function validateCheck($operator, $value): void { } } + /** + * Gets the file size from HTTP headers. + * + * Checks 'OC-Total-Length' first; if unavailable and the method is POST or PUT, + * checks 'Content-Length'. Returns the size as int, float, or false if not found or invalid. + * + * @return int|float|false File size in bytes, or false if unavailable. + */ protected function getFileSizeFromHeader(): int|float|false { + // Already have it cached? if ($this->size !== null) { return $this->size; } $size = $this->request->getHeader('OC-Total-Length'); if ($size === '') { - if (in_array($this->request->getMethod(), ['POST', 'PUT'])) { + // Try fallback for upload methods + $method = $this->request->getMethod(); + if (in_array($method, ['POST', 'PUT'], true)) { $size = $this->request->getHeader('Content-Length'); } } - if ($size === '' || !is_numeric($size)) { - $size = false; + if ($size !== '' && is_numeric($size)) { + $this->size = Util::numericToNumber($size); + } else { + // No valid size header found + $this->size = false; } - - $this->size = Util::numericToNumber($size); + return $this->size; } From f5039750b3b346e88cb6b492641bc2095481edde Mon Sep 17 00:00:00 2001 From: Josh Date: Wed, 24 Sep 2025 11:29:36 -0400 Subject: [PATCH 2/2] chore: fix formatting Signed-off-by: Josh --- apps/workflowengine/lib/Check/FileSize.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/apps/workflowengine/lib/Check/FileSize.php b/apps/workflowengine/lib/Check/FileSize.php index 6337f004a0631..b3a0ba57c845e 100644 --- a/apps/workflowengine/lib/Check/FileSize.php +++ b/apps/workflowengine/lib/Check/FileSize.php @@ -81,12 +81,12 @@ protected function getFileSizeFromHeader(): int|float|false { } if ($size !== '' && is_numeric($size)) { - $this->size = Util::numericToNumber($size); + $this->size = Util::numericToNumber($size); } else { // No valid size header found $this->size = false; } - + return $this->size; }