Skip to content

Commit 7e23ee8

Browse files
authored
Merge pull request #589 from nextcloud/bug/noid/fix-cpu-memory-chart
fix: replace removed success and complete callbacks
2 parents 1ce17e9 + 225b2e7 commit 7e23ee8

File tree

1 file changed

+22
-35
lines changed

1 file changed

+22
-35
lines changed

js/script.js

Lines changed: 22 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -50,24 +50,21 @@
5050
function updateInfo() {
5151
const url = OC.generateUrl('/apps/serverinfo/update')
5252

53-
$.get(url).success(function(response) {
54-
updateCPUStatistics(response.system.cpuload)
55-
updateMemoryStatistics(response.system.mem_total, response.system.mem_free, response.system.swap_total, response.system.swap_free)
56-
}).complete(function() {
57-
setTimeout(updateInfo, 300)
58-
})
53+
$.get(url)
54+
.done(function (response) {
55+
updateCPUStatistics(response.system.cpuload)
56+
updateMemoryStatistics(response.system.mem_total, response.system.mem_free, response.system.swap_total, response.system.swap_free)
57+
})
58+
.always(function () {
59+
setTimeout(updateInfo, 2000)
60+
})
5961
}
6062

6163
setTimeout(updateInfo, 0)
6264
});
6365

64-
$(window).load(function(){
65-
resizeSystemCharts();
66-
});
67-
68-
$(window).resize(function () {
69-
resizeSystemCharts();
70-
});
66+
window.addEventListener('load', resizeSystemCharts)
67+
window.addEventListener('resize', resizeSystemCharts)
7168

7269
function getThemedPrimaryColor() {
7370
return OCA.Theming ? OCA.Theming.color : 'rgb(54, 129, 195)';
@@ -241,10 +238,9 @@
241238
}
242239

243240
function initDiskCharts() {
244-
$.ajax({
245-
url: OC.linkToOCS('apps/serverinfo/api/v1/', 2) + 'diskdata?format=json',
246-
method: "GET",
247-
success: function (response) {
241+
const url = OC.linkToOCS('apps/serverinfo/api/v1/', 2) + 'diskdata?format=json';
242+
$.get(url)
243+
.done(function (response) {
248244
var diskdata = response.ocs.data;
249245
var diskcharts = document.querySelectorAll(".DiskChart");
250246
var i;
@@ -278,35 +274,26 @@
278274
}
279275
});
280276
}
281-
},
282-
error: function (data) {
283-
console.log(data);
284-
}
285-
});
277+
});
286278

287-
var interval = 1000; // 1000 = 1 second, 3000 = 3 seconds
279+
var interval = 10000; // 1000 = 1 second, 3000 = 3 seconds
288280
function doAjax() {
289-
$.ajax({
290-
url: OC.linkToOCS('apps/serverinfo/api/v1/', 2) + 'basicdata?format=json',
291-
method: "GET",
292-
success: function (response) {
281+
const url = OC.linkToOCS('apps/serverinfo/api/v1/', 2) + 'basicdata?format=json';
282+
$.get(url)
283+
.done(function (response) {
293284
var data = response.ocs.data;
294285
document.getElementById("servertime").innerHTML = data.servertime;
295286
document.getElementById("uptime").innerHTML = data.uptime;
296287
for (const thermalzone of data.thermalzones) {
297288
document.getElementById(thermalzone.zone).textContent = thermalzone.temp;
298289
}
299-
},
300-
error: function (data) {
301-
console.log(data);
302-
},
303-
complete: function (data) {
290+
})
291+
.always(function () {
304292
setTimeout(doAjax, interval);
305-
}
306-
});
293+
});
307294
}
308295

309-
setTimeout(doAjax, interval);
296+
setTimeout(doAjax, 0);
310297
}
311298

312299
})(jQuery, OC);

0 commit comments

Comments
 (0)