Skip to content

[stable19] "409 Conflict" on joining a second time in the same conversation #3866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickvergessen merged 23 commits into from
Jul 2, 2020
Merged

[stable19] "409 Conflict" on joining a second time in the same conversation #3866

Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
a1578c9
Optionally return 409 when trying to join a second time
nickvergessen May 15, 2020
fef57e9
Handle duplicated sessions more gracefully with the internal signaling
nickvergessen Apr 16, 2020
6467e6b
Better handle 404 error as well as all other undefined scenarios
nickvergessen Apr 16, 2020
cb9eb66
Also support guests to prevent breaking their sessions
nickvergessen May 15, 2020
d424d08
Return session id, in call flag and last ping
nickvergessen May 15, 2020
ebc4b0a
Always ask if we can join if we are not reloading the page
nickvergessen May 29, 2020
e6e627f
Ask for confirmation to join in case of session conflict
nickvergessen May 29, 2020
73603d4
Automatically force join if the session is "old"
nickvergessen May 29, 2020
2939bd9
Add documentation for the conflict handling
nickvergessen May 29, 2020
18c10ec
Leave the room with the old session
nickvergessen May 29, 2020
77e6ecf
Further pass on the sessionId to leaveRoomAsParticipant
nickvergessen Jun 15, 2020
a4ef453
Show session conflict warning when a session joins again for your own…
nickvergessen Jun 15, 2020
8b350af
Redirect to a plain page to avoid reconnections
nickvergessen Jun 16, 2020
0385e9a
Send a signal to disconnect the old session before killing it
nickvergessen Jun 16, 2020
5733c49
Don't show call state when asking to kill the other session
nickvergessen Jun 16, 2020
8846755
Trigger a vue event when SessionStorage "joined_conversation" changes
nickvergessen Jun 24, 2020
cd0d497
Don't kill the previous session when we navigate away
nickvergessen Jun 24, 2020
159ea23
Handle the disinvite event properly when the session was kicked
nickvergessen Jun 24, 2020
2a5b1ff
Add a hack to check if the dialog was closed via the X
nickvergessen Jun 29, 2020
1faa457
If the user has no participant anymore, it was not a conflict
nickvergessen Jun 29, 2020
7012568
Fix mixin state also when the component is loaded after the state alr…
nickvergessen Jun 30, 2020
4a83d42
Update the session and the call flag when force joining
nickvergessen Jul 1, 2020
25c3b36
Add browser-storage
nickvergessen Jul 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix mixin state also when the component is loaded after the state alr… 
…eady changed

Signed-off-by: Joas Schilling <[email protected]>
  • Loading branch information
@nickvergessen @backportbot
nickvergessen authored and backportbot[bot] committed Jul 1, 2020
commit 70125688a0977fe0cbc04c01a25d59cd9a0850a5
1 change: 1 addition & 0 deletions src/mixins/isInCall.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ export default {

beforeMount() {
EventBus.$on('joinedConversation', this.readSessionStorageJoinedConversation)
this.sessionStorageJoinedConversation = SessionStorage.getItem('joined_conversation')
},

methods: {
Expand Down