Merge pull request #86 from nextcloud/fix/proper_data_resp

MorrisJobke · web-flow · commit 795f171c9b4f · 2018-11-13T15:45:54.000+01:00
Do not call invalid function
diff --git a/lib/BackgroundJobs/MonthlyReport.php b/lib/BackgroundJobs/MonthlyReport.php
@@ -23,6 +23,7 @@
 
 use OC\BackgroundJob\TimedJob;
 use OCA\Survey_Client\AppInfo\Application;
+use OCP\AppFramework\Http;
 
 class MonthlyReport extends TimedJob {
 
@@ -40,7 +41,7 @@ protected function run($argument) {
 		$collector = $application->getContainer()->query('OCA\Survey_Client\Collector');
 		$result = $collector->sendReport();
 
-		if (!$result->succeeded()) {
+		if ($result->getStatus() !== Http::STATUS_OK) {
 			\OC::$server->getLogger()->info('Error while sending usage statistic');
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -23,6 +23,7 @@`
`23`	`23`
`24`	`24`	`use OC\BackgroundJob\TimedJob;`
`25`	`25`	`use OCA\Survey_Client\AppInfo\Application;`
	`26`	`+use OCP\AppFramework\Http;`
`26`	`27`
`27`	`28`	`class MonthlyReport extends TimedJob {`
`28`	`29`
`@@ -40,7 +41,7 @@ protected function run($argument) {`
`40`	`41`	`$collector = $application->getContainer()->query('OCA\Survey_Client\Collector');`
`41`	`42`	`$result = $collector->sendReport();`
`42`	`43`
`43`		`- if (!$result->succeeded()) {`
	`44`	`+ if ($result->getStatus() !== Http::STATUS_OK) {`
`44`	`45`	`\OC::$server->getLogger()->info('Error while sending usage statistic');`
`45`	`46`	`}`
`46`	`47`	`}`