Use write permission when possible

juliusknorr · backportbot[bot] · commit 039d151f373e · 2021-03-11T12:23:42.000Z
Signed-off-by: Julius Härtl &lt;jus@bitgrid.net&gt;
diff --git a/lib/Service/DocumentService.php b/lib/Service/DocumentService.php
@@ -405,7 +405,13 @@ public function getFileById($fileId, $userId = null): Node {
 			throw new NotFoundException();
 		}
 
-		return $files[0];
+		// Workaround to always open files with edit permissions if multiple occurences of
+		// the same file id are in the user home, ideally we should also track the path of the file when opening
+		usort($files, function (Node $a, Node $b) {
+			return ($a->getPermissions() & Constants::PERMISSION_UPDATE) < ($b->getPermissions() & Constants::PERMISSION_UPDATE);
+		});
+
+		return array_shift($files);
 	}
 
 	/**

Original file line number	Diff line number	Diff line change
`@@ -405,7 +405,13 @@ public function getFileById($fileId, $userId = null): Node {`
`405`	`405`	`throw new NotFoundException();`
`406`	`406`	`}`
`407`	`407`
`408`		`- return $files[0];`
	`408`	`+ // Workaround to always open files with edit permissions if multiple occurences of`
	`409`	`+ // the same file id are in the user home, ideally we should also track the path of the file when opening`
	`410`	`+ usort($files, function (Node $a, Node $b) {`
	`411`	`+ return ($a->getPermissions() & Constants::PERMISSION_UPDATE) < ($b->getPermissions() & Constants::PERMISSION_UPDATE);`
	`412`	`+ });`
	`413`	`+`
	`414`	`+ return array_shift($files);`
`409`	`415`	`}`
`410`	`416`
`411`	`417`	`/**`