Skip to content

Commit 9502110

Browse files
committed
fix(LinkBubble): Limit hide on scroll to editor scroll container
* Add the scroll event listener to the app details pane, not to document * Don't dispatch the scroll event in capture phase Fixes: #5497 Signed-off-by: Jonas <[email protected]>
1 parent dc3f642 commit 9502110

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

src/plugins/LinkBubblePluginView.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ class LinkBubblePluginView {
1111
this.options = options
1212
this.view = view
1313
this.plugin = plugin
14+
this.scrollContainer = document.querySelector('.splitpanes__pane-details')
1415

1516
this.#component = new VueRenderer(LinkBubbleView, {
1617
parent: this.options.parent,
@@ -21,7 +22,7 @@ class LinkBubblePluginView {
2122
})
2223

2324
this.view.dom.addEventListener('dragstart', this.dragOrScrollHandler)
24-
document.addEventListener('scroll', this.dragOrScrollHandler, { capture: true })
25+
this.scrollContainer.addEventListener('scroll', this.dragOrScrollHandler)
2526
}
2627

2728
dragOrScrollHandler = (event) => {
@@ -102,7 +103,7 @@ class LinkBubblePluginView {
102103
destroy() {
103104
this.tippy?.destroy()
104105
this.view.dom.removeEventListener('dragstart', this.dragOrScrollHandler)
105-
document.removeEventListener('scroll', this.dragOrScrollHandler, { capture: true })
106+
this.scrollContainer.removeEventListener('scroll', this.dragOrScrollHandler, { capture: true })
106107
}
107108

108109
}

0 commit comments

Comments
 (0)