Skip to content

Commit 976b830

Browse files
Pytaljuliusknorr
authored andcommitted
chore(cypress): Fix tests
Signed-off-by: Christopher Ng <chrng8@gmail.com>
1 parent 4538aa8 commit 976b830

File tree

3 files changed

+17
-13
lines changed

3 files changed

+17
-13
lines changed

cypress/e2e/nodes/Table.spec.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40,9 +40,9 @@ describe('table plugin', () => {
4040
.should('contain', 'content')
4141

4242
cy.getContent()
43-
.find('[data-text-table-actions="settings"]').click()
43+
.find('[data-text-table-actions="settings"] [aria-label="Actions"]').click()
4444

45-
cy.get('[data-text-table-action="delete"]').click()
45+
cy.get('[data-text-table-action="delete"] [role="menuitem"]').click()
4646
cy.getContent()
4747
.should('not.contain', 'content')
4848
})
@@ -80,7 +80,7 @@ describe('table plugin', () => {
8080
cy.getContent()
8181
.find('table tr:first-child th:first-child button')
8282
.click()
83-
cy.get(`[data-text-table-action="align-column-${align}"]`)
83+
cy.get(`[data-text-table-action="align-column-${align}"] [role="menuitemradio"]`)
8484
.click()
8585
// Check header has correct text align and text is preserved
8686
cy.getContent()
@@ -101,7 +101,7 @@ describe('table plugin', () => {
101101
cy.getContent()
102102
.find('table tr:first-child th:first-child button')
103103
.click()
104-
cy.get('[data-text-table-action="align-column-center"]')
104+
cy.get('[data-text-table-action="align-column-center"] [role="menuitemradio"]')
105105
.click()
106106

107107
// Test before adding a row

cypress/e2e/versions.spec.js

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -26,19 +26,19 @@ describe('Versions', () => {
2626
cy.get('[data-cy-files-list-row-name="' + versionFileName + '"] [data-cy-files-list-row-mtime]').click()
2727
cy.get('.app-sidebar-header').should('be.visible').should('contain', versionFileName)
2828
cy.get('.app-sidebar-tabs__tab:contains("Versions")').click()
29-
cy.get('[data-files-versions-versions-list] li > a').should('have.length', 3)
29+
cy.get('[data-files-versions-versions-list] li a').should('have.length', 3)
3030

31-
cy.get('[data-files-versions-versions-list] li > a').eq(1).click()
31+
cy.get('[data-files-versions-versions-list] li a').eq(1).click()
3232
cy.get('.viewer__content #read-only-editor')
3333
.find('h1 [data-node-view-content]')
3434
.should('have.text', 'V2')
3535

36-
cy.get('[data-files-versions-versions-list] li > a').eq(2).click()
36+
cy.get('[data-files-versions-versions-list] li a').eq(2).click()
3737
cy.get('.viewer__content #read-only-editor')
3838
.find('h1 [data-node-view-content]')
3939
.should('have.text', 'V1')
4040

41-
cy.get('[data-files-versions-versions-list] li > a').eq(0).click()
41+
cy.get('[data-files-versions-versions-list] li a').eq(0).click()
4242
cy.getContent()
4343
.find('h1 [data-node-view-content]')
4444
.should('have.text', 'V3')
@@ -60,19 +60,19 @@ describe('Versions', () => {
6060

6161
cy.get('.app-sidebar-tabs__tab:contains("Versions")').click()
6262

63-
cy.get('[data-files-versions-versions-list] li > a').should('have.length', 3)
63+
cy.get('[data-files-versions-versions-list] li a').should('have.length', 3)
6464

65-
cy.get('[data-files-versions-versions-list] li > a').eq(1).click()
65+
cy.get('[data-files-versions-versions-list] li a').eq(1).click()
6666
cy.get('.viewer__content #read-only-editor')
6767
.find('h1 [data-node-view-content]')
6868
.should('have.text', 'V2')
6969

70-
cy.get('[data-files-versions-versions-list] li > a').eq(2).click()
70+
cy.get('[data-files-versions-versions-list] li a').eq(2).click()
7171
cy.get('.viewer__content #read-only-editor')
7272
.find('h1 [data-node-view-content]')
7373
.should('have.text', 'V1')
7474

75-
cy.get('[data-files-versions-versions-list] li > a').eq(0).click()
75+
cy.get('[data-files-versions-versions-list] li a').eq(0).click()
7676
cy.getContent()
7777
.find('h1 [data-node-view-content]')
7878
.should('have.text', 'V3')
@@ -97,7 +97,7 @@ describe('Versions', () => {
9797

9898
cy.get('.app-sidebar-tabs__tab:contains("Versions")').click()
9999

100-
cy.get('[data-files-versions-versions-list] li > a').should('have.length', 3)
100+
cy.get('[data-files-versions-versions-list] li a').should('have.length', 3)
101101

102102
cy.get('[data-files-versions-versions-list] li').eq(2)
103103
.find('button.action-item__menutoggle').first().click({ force: true })

cypress/support/e2e.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,10 @@ before(() => {
2222
return false
2323
}
2424

25+
if (err.message.includes('clearFocusTrap')) {
26+
return false
27+
}
28+
2529
return true
2630
})
2731
})

0 commit comments

Comments
 (0)