From 7db6defdc579399b90d80a5a85521fcd843ceeca Mon Sep 17 00:00:00 2001 From: Jonas Date: Mon, 30 Jun 2025 12:34:22 +0200 Subject: [PATCH] debug(SessionMiddleware): Log if we have an invalid session We have spotted occurrences of this in combination with out-of-sync situations, so let's log it for now to better debug when this happens. Signed-off-by: Jonas --- lib/Middleware/SessionMiddleware.php | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/lib/Middleware/SessionMiddleware.php b/lib/Middleware/SessionMiddleware.php index 17955455bed..84a603e387c 100644 --- a/lib/Middleware/SessionMiddleware.php +++ b/lib/Middleware/SessionMiddleware.php @@ -30,6 +30,7 @@ use OCP\IUserSession; use OCP\Share\Exceptions\ShareNotFound; use OCP\Share\IManager as ShareManager; +use Psr\Log\LoggerInterface; use ReflectionException; class SessionMiddleware extends Middleware { @@ -43,6 +44,7 @@ public function __construct( private IRootFolder $rootFolder, private ShareManager $shareManager, private IL10N $l10n, + private LoggerInterface $logger, ) { } @@ -99,11 +101,15 @@ private function assertDocumentSession(ISessionAwareController $controller): voi $session = $this->sessionService->getValidSession($documentId, $sessionId, $token); if (!$session) { + // We spotted occurrences of this in combination with out-of-sync situations, so let's log it for now. + $this->logger->error('Could not find document session for document id' . $documentId . ' and session id ' . $sessionId); throw new InvalidSessionException(); } $document = $this->documentService->getDocument($documentId); if (!$document) { + // We spotted occurrences of this in combination with out-of-sync situations, so let's log it for now. + $this->logger->error('Could not find document for documentId ' . $documentId); throw new InvalidSessionException(); }