feat(schematics): display provided path when displaying an error (#1208)

koumatsumoto · brandonroberts · commit 91cc6ed88f06 · 2018-07-28T22:09:45.000-05:00
Closes #1200
diff --git a/modules/effects/schematics-core/utility/find-module.ts b/modules/effects/schematics-core/utility/find-module.ts
@@ -57,7 +57,7 @@ export function findModuleFromOptions(
     } else if (host.exists(modulePath + '/' + moduleBaseName + '.module.ts')) {
       return normalize(modulePath + '/' + moduleBaseName + '.module.ts');
     } else {
-      throw new Error('Specified module does not exist');
+      throw new Error(`Specified module path ${modulePath} does not exist`);
     }
   }
 }
diff --git a/modules/effects/schematics-core/utility/ngrx-utils.ts b/modules/effects/schematics-core/utility/ngrx-utils.ts
@@ -16,7 +16,7 @@ export function addReducerToState(options: any): Rule {
     const reducersPath = normalize(`/${options.path}/${options.reducers}`);
 
     if (!host.exists(reducersPath)) {
-      throw new Error('Specified reducers path does not exist');
+      throw new Error(`Specified reducers path ${reducersPath} does not exist`);
     }
 
     const text = host.read(reducersPath);
@@ -192,7 +192,7 @@ export function addReducerImportToNgModule(options: any): Rule {
 
     const modulePath = options.module;
     if (!host.exists(options.module)) {
-      throw new Error('Specified module does not exist');
+      throw new Error(`Specified module path ${modulePath} does not exist`);
     }
 
     const text = host.read(modulePath);
diff --git a/modules/entity/schematics-core/utility/find-module.ts b/modules/entity/schematics-core/utility/find-module.ts
@@ -57,7 +57,7 @@ export function findModuleFromOptions(
     } else if (host.exists(modulePath + '/' + moduleBaseName + '.module.ts')) {
       return normalize(modulePath + '/' + moduleBaseName + '.module.ts');
     } else {
-      throw new Error('Specified module does not exist');
+      throw new Error(`Specified module path ${modulePath} does not exist`);
     }
   }
 }
diff --git a/modules/entity/schematics-core/utility/ngrx-utils.ts b/modules/entity/schematics-core/utility/ngrx-utils.ts
@@ -16,7 +16,7 @@ export function addReducerToState(options: any): Rule {
     const reducersPath = normalize(`/${options.path}/${options.reducers}`);
 
     if (!host.exists(reducersPath)) {
-      throw new Error('Specified reducers path does not exist');
+      throw new Error(`Specified reducers path ${reducersPath} does not exist`);
     }
 
     const text = host.read(reducersPath);
@@ -192,7 +192,7 @@ export function addReducerImportToNgModule(options: any): Rule {
 
     const modulePath = options.module;
     if (!host.exists(options.module)) {
-      throw new Error('Specified module does not exist');
+      throw new Error(`Specified module path ${modulePath} does not exist`);
     }
 
     const text = host.read(modulePath);
diff --git a/modules/router-store/schematics-core/utility/find-module.ts b/modules/router-store/schematics-core/utility/find-module.ts
@@ -57,7 +57,7 @@ export function findModuleFromOptions(
     } else if (host.exists(modulePath + '/' + moduleBaseName + '.module.ts')) {
       return normalize(modulePath + '/' + moduleBaseName + '.module.ts');
     } else {
-      throw new Error('Specified module does not exist');
+      throw new Error(`Specified module path ${modulePath} does not exist`);
     }
   }
 }
diff --git a/modules/router-store/schematics-core/utility/ngrx-utils.ts b/modules/router-store/schematics-core/utility/ngrx-utils.ts
@@ -16,7 +16,7 @@ export function addReducerToState(options: any): Rule {
     const reducersPath = normalize(`/${options.path}/${options.reducers}`);
 
     if (!host.exists(reducersPath)) {
-      throw new Error('Specified reducers path does not exist');
+      throw new Error(`Specified reducers path ${reducersPath} does not exist`);
     }
 
     const text = host.read(reducersPath);
@@ -192,7 +192,7 @@ export function addReducerImportToNgModule(options: any): Rule {
 
     const modulePath = options.module;
     if (!host.exists(options.module)) {
-      throw new Error('Specified module does not exist');
+      throw new Error(`Specified module path ${modulePath} does not exist`);
     }
 
     const text = host.read(modulePath);
diff --git a/modules/schematics-core/utility/find-module.ts b/modules/schematics-core/utility/find-module.ts
@@ -57,7 +57,7 @@ export function findModuleFromOptions(
     } else if (host.exists(modulePath + '/' + moduleBaseName + '.module.ts')) {
       return normalize(modulePath + '/' + moduleBaseName + '.module.ts');
     } else {
-      throw new Error('Specified module does not exist');
+      throw new Error(`Specified module path ${modulePath} does not exist`);
     }
   }
 }
diff --git a/modules/schematics-core/utility/ngrx-utils.ts b/modules/schematics-core/utility/ngrx-utils.ts
@@ -16,7 +16,7 @@ export function addReducerToState(options: any): Rule {
     const reducersPath = normalize(`/${options.path}/${options.reducers}`);
 
     if (!host.exists(reducersPath)) {
-      throw new Error('Specified reducers path does not exist');
+      throw new Error(`Specified reducers path ${reducersPath} does not exist`);
     }
 
     const text = host.read(reducersPath);
@@ -192,7 +192,7 @@ export function addReducerImportToNgModule(options: any): Rule {
 
     const modulePath = options.module;
     if (!host.exists(options.module)) {
-      throw new Error('Specified module does not exist');
+      throw new Error(`Specified module path ${modulePath} does not exist`);
     }
 
     const text = host.read(modulePath);
diff --git a/modules/schematics/schematics-core/utility/find-module.ts b/modules/schematics/schematics-core/utility/find-module.ts
@@ -57,7 +57,7 @@ export function findModuleFromOptions(
     } else if (host.exists(modulePath + '/' + moduleBaseName + '.module.ts')) {
       return normalize(modulePath + '/' + moduleBaseName + '.module.ts');
     } else {
-      throw new Error('Specified module does not exist');
+      throw new Error(`Specified module path ${modulePath} does not exist`);
     }
   }
 }
diff --git a/modules/schematics/schematics-core/utility/ngrx-utils.ts b/modules/schematics/schematics-core/utility/ngrx-utils.ts
@@ -16,7 +16,7 @@ export function addReducerToState(options: any): Rule {
     const reducersPath = normalize(`/${options.path}/${options.reducers}`);
 
     if (!host.exists(reducersPath)) {
-      throw new Error('Specified reducers path does not exist');
+      throw new Error(`Specified reducers path ${reducersPath} does not exist`);
     }
 
     const text = host.read(reducersPath);
@@ -192,7 +192,7 @@ export function addReducerImportToNgModule(options: any): Rule {
 
     const modulePath = options.module;
     if (!host.exists(options.module)) {
-      throw new Error('Specified module does not exist');
+      throw new Error(`Specified module path ${modulePath} does not exist`);
     }
 
     const text = host.read(modulePath);
diff --git a/modules/schematics/src/effect/index.ts b/modules/schematics/src/effect/index.ts
@@ -35,7 +35,7 @@ function addImportToNgModule(options: EffectOptions): Rule {
     }
 
     if (!host.exists(modulePath)) {
-      throw new Error('Specified module does not exist');
+      throw new Error(`Specified module path ${modulePath} does not exist`);
     }
 
     const text = host.read(modulePath);
diff --git a/modules/schematics/src/store/index.ts b/modules/schematics/src/store/index.ts
@@ -35,7 +35,7 @@ function addImportToNgModule(options: StoreOptions): Rule {
     }
 
     if (!host.exists(modulePath)) {
-      throw new Error('Specified module does not exist');
+      throw new Error(`Specified module path ${modulePath} does not exist`);
     }
 
     const text = host.read(modulePath);
diff --git a/modules/store-devtools/schematics-core/utility/find-module.ts b/modules/store-devtools/schematics-core/utility/find-module.ts
@@ -57,7 +57,7 @@ export function findModuleFromOptions(
     } else if (host.exists(modulePath + '/' + moduleBaseName + '.module.ts')) {
       return normalize(modulePath + '/' + moduleBaseName + '.module.ts');
     } else {
-      throw new Error('Specified module does not exist');
+      throw new Error(`Specified module path ${modulePath} does not exist`);
     }
   }
 }
diff --git a/modules/store-devtools/schematics-core/utility/ngrx-utils.ts b/modules/store-devtools/schematics-core/utility/ngrx-utils.ts
@@ -16,7 +16,7 @@ export function addReducerToState(options: any): Rule {
     const reducersPath = normalize(`/${options.path}/${options.reducers}`);
 
     if (!host.exists(reducersPath)) {
-      throw new Error('Specified reducers path does not exist');
+      throw new Error(`Specified reducers path ${reducersPath} does not exist`);
     }
 
     const text = host.read(reducersPath);
@@ -192,7 +192,7 @@ export function addReducerImportToNgModule(options: any): Rule {
 
     const modulePath = options.module;
     if (!host.exists(options.module)) {
-      throw new Error('Specified module does not exist');
+      throw new Error(`Specified module path ${modulePath} does not exist`);
     }
 
     const text = host.read(modulePath);
diff --git a/modules/store/schematics-core/utility/find-module.ts b/modules/store/schematics-core/utility/find-module.ts
@@ -57,7 +57,7 @@ export function findModuleFromOptions(
     } else if (host.exists(modulePath + '/' + moduleBaseName + '.module.ts')) {
       return normalize(modulePath + '/' + moduleBaseName + '.module.ts');
     } else {
-      throw new Error('Specified module does not exist');
+      throw new Error(`Specified module path ${modulePath} does not exist`);
     }
   }
 }
diff --git a/modules/store/schematics-core/utility/ngrx-utils.ts b/modules/store/schematics-core/utility/ngrx-utils.ts
@@ -16,7 +16,7 @@ export function addReducerToState(options: any): Rule {
     const reducersPath = normalize(`/${options.path}/${options.reducers}`);
 
     if (!host.exists(reducersPath)) {
-      throw new Error('Specified reducers path does not exist');
+      throw new Error(`Specified reducers path ${reducersPath} does not exist`);
     }
 
     const text = host.read(reducersPath);
@@ -192,7 +192,7 @@ export function addReducerImportToNgModule(options: any): Rule {
 
     const modulePath = options.module;
     if (!host.exists(options.module)) {
-      throw new Error('Specified module does not exist');
+      throw new Error(`Specified module path ${modulePath} does not exist`);
     }
 
     const text = host.read(modulePath);

Original file line number	Diff line number	Diff line change
`@@ -57,7 +57,7 @@ export function findModuleFromOptions(`
`57`	`57`	`} else if (host.exists(modulePath + '/' + moduleBaseName + '.module.ts')) {`
`58`	`58`	`return normalize(modulePath + '/' + moduleBaseName + '.module.ts');`
`59`	`59`	`} else {`
`60`		`- throw new Error('Specified module does not exist');`
	`60`	+ throw new Error(`Specified module path ${modulePath} does not exist`);
`61`	`61`	`}`
`62`	`62`	`}`
`63`	`63`	`}`
Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@ export function addReducerToState(options: any): Rule {`
`16`	`16`	const reducersPath = normalize(`/${options.path}/${options.reducers}`);
`17`	`17`
`18`	`18`	`if (!host.exists(reducersPath)) {`
`19`		`- throw new Error('Specified reducers path does not exist');`
	`19`	+ throw new Error(`Specified reducers path ${reducersPath} does not exist`);
`20`	`20`	`}`
`21`	`21`
`22`	`22`	`const text = host.read(reducersPath);`
`@@ -192,7 +192,7 @@ export function addReducerImportToNgModule(options: any): Rule {`
`192`	`192`
`193`	`193`	`const modulePath = options.module;`
`194`	`194`	`if (!host.exists(options.module)) {`
`195`		`- throw new Error('Specified module does not exist');`
	`195`	+ throw new Error(`Specified module path ${modulePath} does not exist`);
`196`	`196`	`}`
`197`	`197`
`198`	`198`	`const text = host.read(modulePath);`