Skip to content

feat(Store): add META_REDUCERS replacement migration#1640

Merged
brandonroberts merged 2 commits into
masterfrom
pr/meta-reducers-migration
Apr 1, 2019
Merged

feat(Store): add META_REDUCERS replacement migration#1640
brandonroberts merged 2 commits into
masterfrom
pr/meta-reducers-migration

Conversation

@timdeschryver

Copy link
Copy Markdown
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Users can provide meta reducers with META_REDUCERS

Closes #

What is the new behavior?

Users can provide meta reducers with USER_PROVIDED_META_REDUCERS

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

This migration will replace all META_REDUCERS occurrences to USER_PROVIDED_META_REDUCERS on ng update - this breaking change was introduced in #1613.

@timdeschryver

Copy link
Copy Markdown
Member Author

I think the implementation of the linter is finished, I just don't know if also have to add a updatePackage rule in the migration.

@brandonroberts

Copy link
Copy Markdown
Member

An updatePackage rule for @ngrx/store?

@timdeschryver

Copy link
Copy Markdown
Member Author

Yes, mainly for @ngrx/store to upgrade it to version 8.
If I'm not mistaken, it isn't needed for the other packages - they will be automatically updated? But I don't know if that's the case for @ngrx/store since we're proving a migration with this PR.

@ngrxbot

ngrxbot commented Mar 20, 2019

Copy link
Copy Markdown
Collaborator

Preview docs changes for fbfbbd1 at https://previews.ngrx.io/pr1640-fbfbbd1/

@timdeschryver timdeschryver marked this pull request as ready for review March 31, 2019 14:09
@brandonroberts brandonroberts merged commit 57bacf5 into master Apr 1, 2019
@brandonroberts brandonroberts deleted the pr/meta-reducers-migration branch April 1, 2019 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants