Skip to content

feat(store): warn when same action is registered#1801

Merged
brandonroberts merged 1 commit into
masterfrom
pr/reducer-warning
Apr 25, 2019
Merged

feat(store): warn when same action is registered#1801
brandonroberts merged 1 commit into
masterfrom
pr/reducer-warning

Conversation

@timdeschryver

Copy link
Copy Markdown
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #1758

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@ngrxbot

ngrxbot commented Apr 24, 2019

Copy link
Copy Markdown
Collaborator

Preview docs changes for e349629 at https://previews.ngrx.io/pr1801-e349629/

@brandonroberts brandonroberts merged commit ecda5f7 into master Apr 25, 2019
@brandonroberts brandonroberts deleted the pr/reducer-warning branch April 25, 2019 02:12
timdeschryver added a commit that referenced this pull request May 8, 2019
brandonroberts pushed a commit that referenced this pull request May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Store: new reducer creator should warn users about duplicate actions within the same reducer

3 participants