Skip to content

fix(example): circular dep#1833

Merged
brandonroberts merged 1 commit into
masterfrom
pr/example-cycle-dep
May 7, 2019
Merged

fix(example): circular dep#1833
brandonroberts merged 1 commit into
masterfrom
pr/example-cycle-dep

Conversation

@timdeschryver

Copy link
Copy Markdown
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

The #1808 PR introduced a circular dep, and the example-app couldn't be served locally.
Related to #1684

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@ngrxbot

ngrxbot commented May 7, 2019

Copy link
Copy Markdown
Collaborator

Preview docs changes for 388a52b at https://previews.ngrx.io/pr1833-388a52b/

@brandonroberts brandonroberts merged commit 1fbd59c into master May 7, 2019
@brandonroberts brandonroberts deleted the pr/example-cycle-dep branch May 7, 2019 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants