feat(router-store) Add base router selectors by jasonhodges · Pull Request #1874 · ngrx/platform

jasonhodges · 2019-05-18T14:12:27Z

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our guidelines: https://github.com/ngrx/platform/blob/master/CONTRIBUTING.md#commit
Tests for the changes have been added (for bug fixes / features)
Documentation has been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?
Adds base set of selectors for Router Store

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #
#1854

What is the new behavior?

Exposes base set of selectors user may use in reducer, similar to the ones of Entity

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

- create initial spec - tested selectors retrievable from example app

ngrxbot · 2019-05-18T14:20:58Z

Preview docs changes for b3af493 at https://previews.ngrx.io/pr1874-b3af493/

- test remaining selectors - update mock data - tested selectors retrievable from example app - add routeTraverse helper function for shared functionality

ngrxbot · 2019-05-21T04:23:20Z

Preview docs changes for c3fa700 at https://previews.ngrx.io/pr1874-c3fa700/

- utilize createSelectors() internally

ngrxbot · 2019-05-23T05:01:48Z

Preview docs changes for 7c37ccd at https://previews.ngrx.io/pr1874-7c37ccd/

- correct unit tests

ngrxbot · 2019-05-24T14:10:19Z

Preview docs changes for c0e82bf at https://previews.ngrx.io/pr1874-c0e82bf/

This reverts commit 0f6a2fd.

ngrxbot · 2019-05-24T15:21:42Z

Preview docs changes for 0e1ef39 at https://previews.ngrx.io/pr1874-0e1ef39/

ngrxbot · 2019-05-24T15:27:20Z

Preview docs changes for 04583bb at https://previews.ngrx.io/pr1874-04583bb/

- correct tests AGAIN

ngrxbot · 2019-05-24T16:26:46Z

Preview docs changes for a276b48 at https://previews.ngrx.io/pr1874-a276b48/

- add Router selectors documentation

ngrxbot · 2019-05-26T14:17:15Z

Preview docs changes for b512528 at https://previews.ngrx.io/pr1874-b512528/

ngrxbot · 2019-05-26T14:32:48Z

Preview docs changes for face309 at https://previews.ngrx.io/pr1874-face309/

- put documentation in correct location

- remove check for selectState since required

ngrxbot · 2019-05-28T19:23:42Z

Preview docs changes for a8d9738 at https://previews.ngrx.io/pr1874-a8d9738/

brandonroberts · 2019-05-29T17:37:23Z

@jasonhodges We also need to mention in the docs that this works with the built in reducer provider by @ngrx/router-store. If you use your own custom serializer, you'll need to provide your own selectors if they do not adhere to the same shape.

- update documentation based off review

ngrxbot · 2019-05-29T19:10:37Z

Preview docs changes for e354684 at https://previews.ngrx.io/pr1874-e354684/

- link out to custom serializer

ngrxbot · 2019-05-29T19:23:15Z

Preview docs changes for 3abcc7d at https://previews.ngrx.io/pr1874-3abcc7d/

- remove unnecessary type from model - add additional unit tests - correct documentation wording

ngrxbot · 2019-05-29T21:18:57Z

Preview docs changes for 3acc6dd at https://previews.ngrx.io/pr1874-3acc6dd/

- remove left over commented code

ngrxbot · 2019-05-29T21:42:26Z

Preview docs changes for 729093b at https://previews.ngrx.io/pr1874-729093b/

ngrxbot · 2019-05-29T22:01:23Z

Preview docs changes for 5a27f45 at https://previews.ngrx.io/pr1874-5a27f45/

brandonroberts · 2019-05-29T22:56:22Z

Thanks @jasonhodges!

Jason Hodges and others added 2 commits May 16, 2019 16:45

feat(router-store) Add base router selectors

4ac2170

feat(router-store) Add base router selectors

b3af493

- create initial spec - tested selectors retrievable from example app

jasonhodges changed the title ~~Pr/router store selectors~~ feat(router-store) Add base router selectors May 18, 2019

yngvebn reviewed May 20, 2019

View reviewed changes

Comment thread modules/router-store/src/models.ts Outdated

feat(router-store) Add base router selectors

c3fa700

- test remaining selectors - update mock data - tested selectors retrievable from example app - add routeTraverse helper function for shared functionality

brandonroberts added the WIP Not ready for review label May 21, 2019

feat(router-store) Add base router selectors

7c37ccd

- utilize createSelectors() internally

jasonhodges added 2 commits May 24, 2019 07:51

feat(router-store) Add base router selectors

0f6a2fd

- correct unit tests

feat(router-store) Add base router selectors

c0e82bf

- correct unit tests

revert: feat(router-store) Add base router selectors

04583bb

This reverts commit 0f6a2fd.

jasonhodges force-pushed the pr/router-store-selectors branch from 0e1ef39 to 04583bb Compare May 24, 2019 15:15

feat(router-store) Add base router selectors

a276b48

- correct tests AGAIN

feat(router-store) Add base router selectors

b512528

- add Router selectors documentation

jasonhodges marked this pull request as ready for review May 26, 2019 14:13

Merge branch 'master' into pr/router-store-selectors

face309

jasonhodges added 2 commits May 28, 2019 09:26

feat(router-store) Add base router selectors

fc8fee9

- put documentation in correct location

feat(router-store) Add base router selectors

a8d9738

- remove check for selectState since required

brandonroberts removed the WIP Not ready for review label May 29, 2019

ThomasBurleson reviewed May 29, 2019

View reviewed changes

Comment thread projects/ngrx.io/content/guide/router-store/selectors.md Outdated

brandonroberts requested changes May 29, 2019

View reviewed changes

feat(router-store) Add base router selectors

e354684

- update documentation based off review

feat(router-store) Add base router selectors

3abcc7d

- link out to custom serializer

brandonroberts approved these changes May 29, 2019

View reviewed changes

feat(router-store) Add base router selectors

3acc6dd

- remove unnecessary type from model - add additional unit tests - correct documentation wording

feat(router-store) Add base router selectors

729093b

- remove left over commented code

chore: expand export for router selectors

5a27f45

brandonroberts merged commit 21c67cc into ngrx:master May 29, 2019

Uh oh!

Conversation

jasonhodges commented May 18, 2019

PR Checklist

PR Type

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

Other information

Uh oh!

ngrxbot commented May 18, 2019

Uh oh!

Uh oh!

ngrxbot commented May 21, 2019

Uh oh!

ngrxbot commented May 23, 2019

Uh oh!

ngrxbot commented May 24, 2019

Uh oh!

ngrxbot commented May 24, 2019

Uh oh!

ngrxbot commented May 24, 2019

Uh oh!

ngrxbot commented May 24, 2019

Uh oh!

ngrxbot commented May 26, 2019

Uh oh!

ngrxbot commented May 26, 2019

Uh oh!

ngrxbot commented May 28, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

brandonroberts commented May 29, 2019

Uh oh!

ngrxbot commented May 29, 2019

Uh oh!

ngrxbot commented May 29, 2019

Uh oh!

ngrxbot commented May 29, 2019

Uh oh!

ngrxbot commented May 29, 2019

Uh oh!

ngrxbot commented May 29, 2019

Uh oh!

brandonroberts commented May 29, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants