fix(data): allow ChangeSetItemFactory to update entities with number ids#1995
Merged
Conversation
Allow the `update` method of ChangeSetItemFactory to accept entities with numerical IDs. This seems to be the intent, as the `Update<T>` it accepts can use either a string or a number for the ID, while the `update` method only allows for string IDs Closes #1988
Collaborator
|
Preview docs changes for 797391d at https://previews.ngrx.io/pr1995-797391d/ |
brandonroberts
approved these changes
Jul 7, 2019
Member
|
Thanks @allout58! |
jordanpowell88
pushed a commit
to jordanpowell88/platform
that referenced
this pull request
Nov 14, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
ChangeSetItemFactory.updateonly allows for entities withstringtype IDsCloses #1988
What is the new behavior?
ChangeSetItemFactory.updateallows for entities withstringornumbertype IDs, to match withUpdate<T>Does this PR introduce a breaking change?
Other information