fix(store): improve consistency of memoized selector result when projection fails#2101
Merged
brandonroberts merged 1 commit intoSep 7, 2019
Conversation
Collaborator
|
Preview docs changes for ce2c2b6 at https://previews.ngrx.io/pr2101-ce2c2b6/ |
timdeschryver
requested changes
Aug 31, 2019
…ection fails A memoized selector projection now consistently fails after the first evaluation, if it is evaluated again with the same state, instead of returning that last successful evaluation result from a previous state. Closes ngrx#2100
REPLicated
force-pushed
the
fix/consistent-memoization-if-error
branch
from
ce2c2b6 to
1991c7d
Compare
Collaborator
|
Preview docs changes for 1991c7d at https://previews.ngrx.io/pr2101-1991c7d/ |
timdeschryver
approved these changes
Sep 1, 2019
jordanpowell88
pushed a commit
to jordanpowell88/platform
that referenced
this pull request
Nov 14, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
See description in #2100
What is the new behavior?
Closes #2100
See description in #2100
Does this PR introduce a breaking change?
Other information