fix(store): improve types for string selectors#2174
Merged
Conversation
1 task
Collaborator
|
Preview docs changes for 89dd230 at https://previews.ngrx.io/pr2174-89dd230/ |
| this.store | ||
| .pipe( | ||
| select(this.stateKey), | ||
| select(this.stateKey as any), |
Member
There was a problem hiding this comment.
Looks like router_store needs some typing cleanup :-/
alex-okrushko
approved these changes
Oct 27, 2019
Member
Author
|
@macjohnny fyi, we decided to improve the typings |
jordanpowell88
pushed a commit
to jordanpowell88/platform
that referenced
this pull request
Nov 14, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Closes #
The string selectors don't have the correct types:
anyWhat is the new behavior?
The new behavior will infer correctly and will throw errors if the state property is missing.
Does this PR introduce a breaking change?
Other information
Similar PRs:
/cc @alex-okrushko