Schematic for customisable error handling migration#2335
Merged
brandonroberts merged 1 commit intoJan 30, 2020
Merged
Conversation
zakhenry
changed the title
zakhenry
commented
Jan 25, 2020
Collaborator
|
Preview docs changes for eefe761 at https://previews.ngrx.io/pr2335-eefe761/ |
timdeschryver
requested changes
Jan 26, 2020
zakhenry
force-pushed
the
feat/customisable-error-handling-migration
branch
2 times, most recently
from
82c0f47 to
a4b7e47
Compare
zakhenry
force-pushed
the
feat/customisable-error-handling-migration
branch
from
a4b7e47 to
fe07ddb
Compare
Contributor
Author
|
Rebased on master now that the dependent PR has merged. |
Member
|
I like this approach more in comparison to what we first had 👏 |
… error handler config key
zakhenry
force-pushed
the
feat/customisable-error-handling-migration
branch
from
fe07ddb to
eefe761
Compare
brandonroberts
approved these changes
Jan 30, 2020
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
- [ ] Documentation has been added / updated (for bug fixes / features)PR Type
What kind of change does this PR introduce?
What is the current behavior?
#2295 introduces a breaking change, this PR adds a migration to ease the transition to ngrx@9 for developers.
Closes #
What is the new behavior?
On upgrade to ngrx 9 developers can run the migration to automatically fix the renamed configuration variable
Does this PR introduce a breaking change?
Other information
This PR is pending the merge of #2295, thus it currently contains those commits.