Skip to content

Deprecate toPayload utility function#266

Merged
MikeRyanDev merged 1 commit into
ngrx:masterfrom
karptonite:deprecate-to-payload
Aug 13, 2017
Merged

Deprecate toPayload utility function#266
MikeRyanDev merged 1 commit into
ngrx:masterfrom
karptonite:deprecate-to-payload

Conversation

@karptonite

@karptonite karptonite commented Aug 12, 2017

Copy link
Copy Markdown
Contributor

As discussed here, #161 (comment), this is a pull request to deprecate toPayload. It also adds a bit of documentation for the type-safe ofType method.

Do you think it needs to be mentioned anywhere else in the docs? I could add something to the Migration notes as well, but I wasn't sure it really needed to be there.

This shouldn't be merged until a 4.1 release.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 91.527% when pulling 1ca6755 on karptonite:deprecate-to-payload into ca544dd on ngrx:master.

@MikeRyanDev

Copy link
Copy Markdown
Member

Thanks!

@MikeRyanDev MikeRyanDev merged commit 1cbb2c9 into ngrx:master Aug 13, 2017
brandonroberts added a commit that referenced this pull request Aug 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants