Skip to content

fix(StoreDevtools): Do not send full liftedState on simple actions.#790

Merged
MikeRyanDev merged 1 commit into
ngrx:masterfrom
timblakely:optimize_devtools_extension_updates
Feb 6, 2018
Merged

fix(StoreDevtools): Do not send full liftedState on simple actions.#790
MikeRyanDev merged 1 commit into
ngrx:masterfrom
timblakely:optimize_devtools_extension_updates

Conversation

@timblakely

Copy link
Copy Markdown
Contributor

A number of users have reported significant slowdown when using store-devtools. Slowdowns were more noticeable with larger states and larger values of maxAge.

It appears that @ngrx/store-devtools currently sends the full lifted state to the extension, which requires serializing not just the current state but all previous states that have not been committed. With this change, only the current action and state snapshots are serialized during normal app actions. When app state is recomputed, a full liftedState update is sent.

Note: Also requires optionally propagating maxAge into ReduxDevtoolsExtension.connect.

@MikeRyanDev

Copy link
Copy Markdown
Member

🔥

Thank you for the PR! I'll get this reviewed and tested quickly.

@MikeRyanDev MikeRyanDev merged commit c11504f into ngrx:master Feb 6, 2018
@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.4%) to 92.616% when pulling fd77d3d on timblakely:optimize_devtools_extension_updates into c8560e4 on ngrx:master.

@timblakely timblakely deleted the optimize_devtools_extension_updates branch February 6, 2018 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants