fix(Entity): Avoid for..in iteration in sorted state adapter#805
Merged
Conversation
Member
|
There will probably be a 5.1.0 at some point. Not sure when, but if you need the fixes soon then I would recommend using the nightlies for now. Thanks for these fixes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have just noticed that the changes in commit f871540 introduced to the sorted state adapter the same problem I have already fixed in the unsorted state adapter. So I'm adding the reproducer to those tests as well.
Just one question: Where can we expect these fixes to be released? Is there going to be version
5.0.2anytime soon?