shim: fix submit key loading

This changeset fixes loading of the submit key. The problem was that if the key length was equal 32 then the function will return an error.

Also, I don't think it's a good idea to accept input that is not 32 bytes long, so I changes it to strict equallity check.

Test added.

Author: pepyakin

Cargo.lock

@@ -23,3 +23,6 @@ subxt = { version = "0.32.1" }
 subxt-signer = {version = "0.32.1", features = ["subxt"] }
 sha2 = "0.10.8"
 hex = "0.4.3"
+
+[dev-dependencies]
+temp-dir = "0.1.11"

sugondat-shim/Cargo.toml

@@ -13,8 +13,12 @@ pub use subxt_signer::sr25519::Keypair;
 pub fn load<P: AsRef<Path>>(path: P) -> anyhow::Result<Keypair> {
     let raw = hex::decode(std::fs::read(path)?)?;
     let mut seed: Seed = Seed::default();
-    if raw.len() <= seed.len() {
-        anyhow::bail!("Keyfile length invalid")
+    if raw.len() != seed.len() {
+        anyhow::bail!(
+            "Keyfile length invalid, expected {} bytes, got {} bytes",
+            seed.len(),
+            raw.len()
+        );
     }
     seed.copy_from_slice(&raw[..]);
     Ok(Keypair::from_seed(seed)?)
@@ -24,3 +28,21 @@ pub fn load<P: AsRef<Path>>(path: P) -> anyhow::Result<Keypair> {
 pub fn alice() -> Keypair {
     subxt_signer::sr25519::dev::alice()
 }
+
+#[test]
+fn load_alice_key() {
+    use std::fs;
+    use temp_dir::TempDir;
+    // `subkey inspect //Alice`:
+    const ALICE_SECRET_SEED_HEX: &str =
+        "e5be9a5092b81bca64be81d212e7f2f9eba183bb7a90954f7b76361f6edb5c0a";
+    let dir = TempDir::new().unwrap();
+    let alice_key = dir.child("alice.key");
+    fs::write(&alice_key, ALICE_SECRET_SEED_HEX).unwrap();
+    let actual_alice_pubk = load(&alice_key).unwrap().public_key();
+    let expected_alice_pubk = alice().public_key();
+    assert_eq!(
+        hex::encode(actual_alice_pubk.as_ref()),
+        hex::encode(expected_alice_pubk.as_ref()),
+    );
+}