Skip to content

Support specific getter forms #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 31, 2020
+361 −61
Merged

Support specific getter forms #25

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f5a288b
support specific getter forms
guybedford Oct 31, 2020
8145ce1
wasm impl and updtes
guybedford Oct 31, 2020
306ca55
readme
guybedford Oct 31, 2020
35b2765
readme clarifications
guybedford Oct 31, 2020
88e514c
readme tweak
guybedford Oct 31, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
readme clarifications
  • Loading branch information
@guybedford
guybedford committed Oct 31, 2020
commit 35b27659b5ec2293a7ef7224753dc504310a505e
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ It will in turn underclassify in cases where the identifiers are renamed:
})(exports);
```

`Object.defineProperty` is detected for any usage of the `__esModule` export, as well as the specific value and getter forms:
`Object.defineProperty` is detected for specifically value and getter forms returning an identifier or member expression:

```js
// DETECTS: a, b, c, d, __esModule
Expand All @@ -186,7 +186,7 @@ Object.defineProperty(exports, 'd', { value: 'd' });
Object.defineProperty(exports, '__esModule', { value: true });
```

Other getter structurs or not return a direct identifier or member expression are not detected:
Alternative object definition structures or getter function bodies are not detected:

```js
// DETECTS: NO EXPORTS
Expand Down