This repository was archived by the owner on Apr 22, 2023. It is now read-only.
collected new content #199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TiagoDanin
suggested changes
Jul 8, 2019
Contributor
Author
TiagoDanin
approved these changes
Jul 10, 2019
zeke
suggested changes
Jul 12, 2019
Contributor
zeke
left a comment
zeke
left a comment
There was a problem hiding this comment.
Thanks for taking the initiative here! This is looking great.
One request: Can you also remove 6.x while you're here? (from package.json, from the tests, and the 6.x files too) -- That version is no longer supported: https://github.com/nodejs/Release#release-schedule
Contributor
Author
|
@zeke Done |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding discussion #72 this PR contain the newest docs content
@zeke Could you take a look