test: split test-runner-watch-mode

The test has been flaky for years and new platforms keep popping
up. As it squeezes too many independent test cases into one file,
split them into individual files to avoid masking regressions
and help only mark the real flaky ones as flaky. This might also
help with the flakiness itself by avoiding updating a shared tmpdir
being watched by differet tests and avoiding running all these
time-consuming tests in one file, which can cause a timeout
on slow machines.

PR-URL: #60391
Refs: #49605
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>

Author: joyeecheung

test/common/watch.js

@@ -60,7 +60,7 @@ async function testRunnerWatch({
                       ['--watch', '--test', '--test-reporter=spec',
                        isolation ? `--test-isolation=${isolation}` : '',
                        file ? fixturePaths[file] : undefined].filter(Boolean),
-                      { encoding: 'utf8', stdio: ['inherit', 'pipe', 'inherit'], cwd: tmpdir.path });
+                      { encoding: 'utf8', stdio: 'pipe', cwd: tmpdir.path });
   let stdout = '';
   let currentRun = '';
   const runs = [];

test/parallel/parallel.status

@@ -50,10 +50,6 @@ test-runner-run-watch: PASS, FLAKY
 # https://github.com/nodejs/node/issues/58353
 test-http2-debug: PASS, FLAKY
 
-[$system==linux || $system==win32]
-# https://github.com/nodejs/node/issues/49605
-test-runner-watch-mode: PASS,FLAKY
-
 [$system==macos]
 # https://github.com/nodejs/node/issues/42741
 test-http-server-headers-timeout-keepalive: PASS,FLAKY

test/parallel/test-runner-watch-mode.mjs

@@ -5,3 +5,7 @@ prefix test-runner
 # sample-test                        : PASS,FLAKY
 
 [true] # This section applies to all platforms
+
+# https://github.com/nodejs/node/pull/54888#issuecomment-2351128116
+# TODO(pmarchini): This test is failing when isolation is set to none and must be fixed.
+test-watch-create-isolation-none: SKIP

test/test-runner/test-runner.status

@@ -0,0 +1,8 @@
+// Test --test --watch --test-isolation=none runs tests when a new file is created in the watched directory
+import '../common/index.mjs';
+import { skipIfNoWatch, refreshForTestRunnerWatch, testRunnerWatch } from '../common/watch.js';
+
+skipIfNoWatch();
+refreshForTestRunnerWatch();
+
+await testRunnerWatch({ action: 'create', fileToCreate: 'new-test-file.test.js', isolation: 'none' });

test/test-runner/test-watch-create-isolation-none.mjs

@@ -0,0 +1,8 @@
+// Test --test --watch --test-isolation=process runs tests when a new file is created in the watched directory
+import '../common/index.mjs';
+import { skipIfNoWatch, refreshForTestRunnerWatch, testRunnerWatch } from '../common/watch.js';
+
+skipIfNoWatch();
+refreshForTestRunnerWatch();
+
+await testRunnerWatch({ action: 'create', fileToCreate: 'new-test-file.test.js', isolation: 'process' });

test/test-runner/test-watch-create-isolation-process.mjs

@@ -0,0 +1,8 @@
+// Test --test --watch --test-isolation=none does not throw when deleting a watched test file
+import '../common/index.mjs';
+import { skipIfNoWatch, refreshForTestRunnerWatch, testRunnerWatch } from '../common/watch.js';
+
+skipIfNoWatch();
+refreshForTestRunnerWatch();
+
+await testRunnerWatch({ fileToUpdate: 'test.js', action: 'delete', isolation: 'none' });

test/test-runner/test-watch-delete-isolation-none.mjs

@@ -0,0 +1,8 @@
+// Test --test --watch --test-isolation=process does not throw when deleting a watched test file
+import '../common/index.mjs';
+import { skipIfNoWatch, refreshForTestRunnerWatch, testRunnerWatch } from '../common/watch.js';
+
+skipIfNoWatch();
+refreshForTestRunnerWatch();
+
+await testRunnerWatch({ fileToUpdate: 'test.js', action: 'delete', isolation: 'process' });

test/test-runner/test-watch-delete-isolation-process.mjs

@@ -0,0 +1,8 @@
+// Test --test --watch --test-isolation=none runs tests with dependency repeatedly
+import '../common/index.mjs';
+import { skipIfNoWatch, refreshForTestRunnerWatch, testRunnerWatch } from '../common/watch.js';
+
+skipIfNoWatch();
+refreshForTestRunnerWatch();
+
+await testRunnerWatch({ file: 'test.js', fileToUpdate: 'dependency.js', isolation: 'none' });

test/test-runner/test-watch-dependency-isolation-none.mjs

@@ -0,0 +1,8 @@
+// Test --test --watch --test-isolation=process runs tests with dependency repeatedly
+import '../common/index.mjs';
+import { skipIfNoWatch, refreshForTestRunnerWatch, testRunnerWatch } from '../common/watch.js';
+
+skipIfNoWatch();
+refreshForTestRunnerWatch();
+
+await testRunnerWatch({ file: 'test.js', fileToUpdate: 'dependency.js', isolation: 'process' });