Commit 53b5511
committed
test: make test-debug-process locale-independent
The test `test/parallel/test-debug-process.js` fails on non-English
Windows systems due to a locale-dependent error message string.
The test asserts that a call to `process._debugProcess()` on a
terminated process throws an error with the message
`'The system cannot find the file specified.'`.
While this holds true on an English Windows system,
the test fails on systems with a different display language.
The underlying `WinapiErrnoException` function correctly retrieves the
localized error message from the OS. For example, on a Korean system,
the message is "์ง์ ๋ ํ์ผ์ ์ฐพ์ ์ ์์ต๋๋ค.". This mismatch causes
an `AssertionError`.
This behavior can be verified directly in PowerShell:
# On Windows with English (US) display language
PS> (New-Object System.ComponentModel.Win32Exception 2).Message
The system cannot find the file specified.
# On Windows with Korean display language
PS> (New-Object System.ComponentModel.Win32Exception 2).Message
์ง์ ๋ ํ์ผ์ ์ฐพ์ ์ ์์ต๋๋ค.
To make the test robust and environment-agnostic, this commit changes
the assertion to check the language-independent `error.errno` property,
which is consistently `2` for this type of error, instead of the
localized `error.message`.1 parent cd1a90d commit 53b5511
1 file changed
+1
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
19 | | - | |
| 19 | + | |
20 | 20 | | |
21 | 21 | | |
0 commit comments