Skip to content

Commit 660d573

Browse files
Asaf-Federmanaduh95
authored andcommitted
test,doc: skip --max-old-space-size-percentage on 32-bit platforms
PR-URL: #60144 Backport-PR-URL: #59631 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ulises Gascón <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
1 parent 42c5544 commit 660d573

File tree

3 files changed

+16
-5
lines changed

3 files changed

+16
-5
lines changed

doc/api/cli.md

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1702,14 +1702,17 @@ changes:
17021702

17031703
Specify the maximum size, in bytes, of HTTP headers. Defaults to 16 KiB.
17041704

1705-
### `--max-old-space-size-percentage=PERCENTAGE`
1705+
### `--max-old-space-size-percentage=percentage`
17061706

1707-
Sets the max memory size of V8's old memory section as a percentage of available system memory.
1707+
Sets the maximum memory size of V8's old memory section as a percentage of available system memory.
17081708
This flag takes precedence over `--max-old-space-size` when both are specified.
17091709

1710-
The `PERCENTAGE` parameter must be a number greater than 0 and up to 100. representing the percentage
1710+
The `percentage` parameter must be a number greater than 0 and up to 100, representing the percentage
17111711
of available system memory to allocate to the V8 heap.
17121712

1713+
**Note:** This flag utilizes `--max-old-space-size`, which may be unreliable on 32-bit platforms due to
1714+
integer overflow issues.
1715+
17131716
```bash
17141717
# Using 50% of available system memory
17151718
node --max-old-space-size-percentage=50 index.js

doc/node.1

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -347,14 +347,18 @@ The file used to store localStorage data.
347347
Specify the maximum size of HTTP headers in bytes. Defaults to 16 KiB.
348348
.
349349
.It Fl -max-old-space-size-percentage Ns = Ns Ar percentage
350-
Sets the max memory size of V8's old memory section as a percentage of available system memory.
350+
Sets the maximum memory size of V8's old memory section as a percentage of available system memory.
351351
This flag takes precedence over
352352
.Fl -max-old-space-size
353353
when both are specified.
354354
The
355355
.Ar percentage
356356
parameter must be a number greater than 0 and up to 100, representing the percentage
357357
of available system memory to allocate to the V8 heap.
358+
.Pp
359+
Note: This flag utilizes
360+
.Fl -max-old-space-size ,
361+
which may be unreliable on 32-bit platforms due to integer overflow issues.
358362
.
359363
.It Fl -napi-modules
360364
This option is a no-op.

test/parallel/test-max-old-space-size-percentage.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,11 @@
22

33
// This test validates the --max-old-space-size-percentage flag functionality
44

5-
require('../common');
5+
const common = require('../common');
6+
// This flag utilizes --max-old-space-size, which is unreliable on
7+
// 32-bit platforms due to integer overflow issues.
8+
common.skipIf32Bits();
9+
610
const assert = require('node:assert');
711
const { spawnSync } = require('child_process');
812
const os = require('os');

0 commit comments

Comments
 (0)