fs: fix wrong order of file names in cpSync error message

PR-URL: #59775
Reviewed-By: Dario Piotrowicz <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>

Author: npaun

src/node_file.cc

@@ -3157,7 +3157,7 @@ static void CpSyncCheckPaths(const FunctionCallbackInfo<Value>& args) {
       std::string message =
           "Cannot overwrite non-directory %s with directory %s";
       return THROW_ERR_FS_CP_DIR_TO_NON_DIR(
-          env, message.c_str(), src_path_str, dest_path_str);
+          env, message.c_str(), dest_path_str, src_path_str);
     }
 
     if (!src_is_dir && dest_is_dir) {

test/parallel/test-fs-cp-sync-copy-directory-to-file-error.mjs

@@ -14,11 +14,11 @@ if (isInsideDirWithUnusualChars) {
 tmpdir.refresh();
 
 {
-  const src = nextdir();
+  const src = nextdir('FIRST_DIRECTORY');
   mkdirSync(src, mustNotMutateObjectDeep({ recursive: true }));
   const dest = fixtures.path('copy/kitchen-sink/README.md');
   assert.throws(
     () => cpSync(src, dest),
-    { code: 'ERR_FS_CP_DIR_TO_NON_DIR' }
+    { code: 'ERR_FS_CP_DIR_TO_NON_DIR', message: /non-directory .*README\.md with directory .*FIRST_DIRECTORY/ }
   );
 }