tools,test: enforce best practices to detect never settling promises

PR-URL: #58992
Reviewed-By: Luigi Pinca <[email protected]>

Author: aduh95

test/es-module/test-require-module-tla-retry-import-2.js

@@ -23,4 +23,4 @@ async function test() {
 }
 
 // Run the test twice to check consistency after caching.
-test().then(common.mustCall(test)).catch(common.mustNotCall());
+test().then(common.mustCall(test));

test/es-module/test-require-module-tla-retry-import.js

@@ -22,4 +22,4 @@ async function test() {
 }
 
 // Run the test twice to check consistency after caching.
-test().then(common.mustCall(test)).catch(common.mustNotCall());
+test().then(common.mustCall(test));

test/es-module/test-vm-main-context-default-loader-eval.js

@@ -70,4 +70,4 @@ async function main() {
   }
 }
 
-main().catch(common.mustNotCall());
+main().then(common.mustCall());

test/es-module/test-vm-main-context-default-loader.js

@@ -116,4 +116,4 @@ async function main() {
   }
 }
 
-main().catch(common.mustNotCall());
+main().then(common.mustCall());

test/eslint.config_partial.mjs

@@ -91,6 +91,10 @@ export default [
           selector: "ExpressionStatement>CallExpression:matches([callee.name='rejects'], [callee.object.name='assert'][callee.property.name='rejects'])",
           message: 'Calling `assert.rejects` without `await` or `.then(common.mustCall())` will not detect never-settling promises.',
         },
+        {
+          selector: 'CallExpression[callee.property.name="catch"]>:first-child:matches(CallExpression[callee.object.name="common"][callee.property.name="mustNotCall"], CallExpression[callee.name="mustNotCall"])',
+          message: 'Calling `.catch(common.mustNotCall())` will not detect never-settling promises. Use `.then(common.mustCall())` instead.',
+        },
       ],
 
       // Stylistic rules.

test/module-hooks/test-module-hooks-load-esm-mock.js

@@ -48,4 +48,4 @@ function hook(code, filename) {
     assert.deepStrictEqual({ ...bar }, { $key: 'bar-esm' });
   }
 
-})().catch(common.mustNotCall());
+})().then(common.mustCall());

test/module-hooks/test-module-hooks-load-esm.js

@@ -48,4 +48,4 @@ function hook(code, filename) {
     assert.deepStrictEqual({ ...bar }, { $key: 'bar-esm' });
   }
 
-})().catch(common.mustNotCall());
+})().then(common.mustCall());

test/parallel/test-crypto-async-sign-verify.js

@@ -138,9 +138,9 @@ test('dsa_public.pem', 'dsa_private.pem', 'sha256', false,
       verify('sha256', data, publicKey, signature),
       verify('sha256', data, publicKey, signature),
       verify('sha256', data, publicKey, signature),
-    ]).then(common.mustCall());
+    ]);
   })
-  .catch(common.mustNotCall());
+  .then(common.mustCall());
 }
 
 {

test/parallel/test-fs-open.js

@@ -53,7 +53,7 @@ async function promise() {
   await (await fs.promises.open(__filename, 'r')).close();
 }
 
-promise().then(common.mustCall()).catch(common.mustNotCall());
+promise().then(common.mustCall());
 
 assert.throws(
   () => fs.open(__filename, 'r', 'boom', common.mustNotCall()),

test/parallel/test-stream-readable-async-iterators.js

@@ -690,7 +690,7 @@ async function tests() {
   const it = r[Symbol.asyncIterator]();
   const p = it.return();
   r.emit('close');
-  p.then(common.mustCall()).catch(common.mustNotCall());
+  p.then(common.mustCall());
 }
 
 {