Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 38ae5c4e34bb3395eb567185ceef12fc47771344
Choose a base ref
...
head repository: nodejs/node
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 14cc1abb5662e8baa8ff51875f332d02b1a9a8ab
Choose a head ref
  • 3 commits
  • 3 files changed
  • 3 contributors

Commits on Sep 19, 2017

  1. build: add cpp linting to windows build 

    This PR adds cpp linting to windows build script. After this change,
running command `vcbuild lint` will run both cpp linting and javascript
linting on a windows machine.

Backport-PR-URL: #14879
PR-URL: #11856
Fixes: #11816
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
    @MylesBorins
    liusi authored and MylesBorins committed Sep 19, 2017
    Configuration menu
    Copy the full SHA
    66cdcd9 View commit details
    Browse the repository at this point in the history

  2. build: add lint option to vcbuild.bat help 

    180bec1
PR-URL: #11992
Fixes: #11971
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
    @brennemo @MylesBorins
    brennemo authored and MylesBorins committed Sep 19, 2017
    Configuration menu
    Copy the full SHA
    c9ae894 View commit details
    Browse the repository at this point in the history

  3. build: split up cpplint to avoid long cmd lines 

    Refactors cpplint slightly to allow multiple runs of it. This allows
downstream projects to run cpplint on their dependencies.

Backport-PR-URL: #14879
PR-URL: #14116
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Kunal Pathak <[email protected]>
Reviewed-By: João Reis <[email protected]>
    @kfarnung @MylesBorins
    kfarnung authored and MylesBorins committed Sep 19, 2017
    Configuration menu
    Copy the full SHA
    14cc1ab View commit details
    Browse the repository at this point in the history
Loading