Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: d6f3694080b388026643f9cb096e4d1354eaecb8
Choose a base ref
...
head repository: nodejs/node
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: f55ce7c4f7d8e321f5ba3a227896f16bf3e8ea95
Choose a head ref
  • 2 commits
  • 3 files changed
  • 2 contributors

Commits on Feb 5, 2021

  1. crypto: fix crash when calling digest after piping 

    When piping data into an SHA3 hash, EVP_DigestFinal_ex is called in
hash._flush, bypassing safeguards in the JavaScript layer. Calling
hash.digest causes EVP_DigestFinal_ex to be called again, resulting
in a segmentation fault in the SHA3 implementation of OpenSSL.

A relatively easy solution is to cache the result of calling
EVP_DigestFinal_ex until the Hash object is garbage collected.

PR-URL: #28251
Fixes: #28245
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>

Backport-PR-URL: #37009
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
    @tniessen @richardlau
    tniessen authored and richardlau committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    c16c314 View commit details
    Browse the repository at this point in the history

  2. test: add test that verifies crypto stream pipeline 

    This test fails prior to 990feaf being cherry-picked
due to stream.pipeline with a crypto.Hash not working properly.

That bug also seems to have affected md5.

PR-URL: #37009
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
    @evanlucas @richardlau
    evanlucas authored and richardlau committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    f55ce7c View commit details
    Browse the repository at this point in the history
Loading