tools: whitelist npm directory in .gitignore #17363
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We shouldn't ignore any of the files checked in.
nodejs-github-bot
added
the
meta
addaleax
approved these changes
Nov 28, 2017
cjihrig
approved these changes
Nov 28, 2017
Contributor
Author
|
Should we do this for the entire deps/ |
Member
|
I'm not sure why this is needed, where are we ignoring
|
Contributor
Author
|
We ignore a bunch of types of files that end up not being included when
updating the dep. I noticed this while doing the update. It is very
possible I am mistaken on this. Will do a dry run with 5.6.0 and see if I
can reproduce
…On Nov 28, 2017 9:30 PM, "Gibson Fahnestock" ***@***.***> wrote:
I'm not sure why this is needed, where are we ignoring deps/npm?
[image: image]
<https://user-images.githubusercontent.com/15943089/33319799-daeaa00e-d437-11e7-9f24-0c15874d213b.png>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#17363 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAecV_GU9u3qSM5PSoIpk2wAbHz7BSsoks5s6_zqgaJpZM4QskbP>
.
|
2 tasks
addaleax
added
the
author ready
Contributor
Author
|
Closing in lieux of #17380 |
addaleax
removed
the
author ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We shouldn't ignore any of the files checked in.
/cc @zkat @iarna @gibfahn