Skip to content

trace_events: add node.promises category, rejection counter #22124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jasnell wants to merge 4 commits into from
Closed

trace_events: add node.promises category, rejection counter #22124

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9ca9452
trace_events: add node.promises category, rejection counter
jasnell Aug 2, 2018
825e0d2
[Squash] use atomic_uint64_t
jasnell Aug 4, 2018
1684f43
[Squash] fixup
jasnell Aug 6, 2018
e4e5fdd
[Squash] fixup
jasnell Aug 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
[Squash] fixup
  • Loading branch information
@jasnell
jasnell committed Aug 6, 2018
commit e4e5fdd79f5e893e1a162cac96d2c5b1428a712c
2 changes: 1 addition & 1 deletion test/parallel/test-trace-event-promises.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ if (process.argv[2] === 'child') {
.filter((trace) => trace.cat !== '__metadata');
traces.forEach((trace) => {
assert.strictEqual(trace.pid, proc.pid);
assert(trace.name === 'rejections');
assert.strictEqual(trace.name, 'rejections');
assert(trace.args.unhandled <= 2);
Copy link
Member

@benjamingr benjamingr Aug 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are these <= and not ===?

Copy link
Member Author

@jasnell jasnell Aug 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because there are two of these that are tested, one with a value of 1 another with a value of 2.

Copy link
Member

@benjamingr benjamingr Aug 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still confused about why it's done this way rather than two explicit checks, but won't press it

assert(trace.args.handledAfter <= 1);
});
Expand Down