Skip to content

test: refactor common.expectWarning() #25251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

test: refactor common.expectWarning() #25251

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3d579f6
test: rework `common.expectWarning()`
BridgeAR Dec 28, 2018
b84f495
test: remove common.noWarnCode
BridgeAR Dec 28, 2018
067ced9
fixup: fix documentation
BridgeAR Jan 9, 2019
a64d10b
fixup: further documentation improvements
BridgeAR Jan 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup: further documentation improvements
  • Loading branch information
@BridgeAR
BridgeAR committed Jan 9, 2019
commit a64d10bf0bf5a9d24e0eab4f0ab0c81c2ce117f5
6 changes: 3 additions & 3 deletions test/common/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ expectWarning('DeprecationWarning', [

expectWarning('DeprecationWarning', [
['Foobar is deprecated', 'DEP0XXX'],
['Baz is also deprecated']
['Baz is also deprecated', 'DEP0XX2']
]);

expectWarning('DeprecationWarning', {
Expand All @@ -147,10 +147,10 @@ expectWarning({
DEP0XX1: 'Baz is also deprecated'
},
Warning: [
['Multiple array entries are fine', 'DEP0XXX'],
['Multiple array entries are fine', 'SpecialWarningCode'],
['No code is also fine']
],
SingleEntry: ['This will also work', 'DEP0XXX'],
SingleEntry: ['This will also work', 'WarningCode'],
SingleString: 'Single string entries without code will also work'
});
```
Expand Down