Skip to content

Test fix description #28351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Test fix description #28351

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0b2acb3
test: updating description
Angelfire Jun 21, 2019
ebb4ccd
test: updating description
Angelfire Jun 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
test: updating description 
This description was fixed. Test are working fine, but the description was not correct
  • Loading branch information
@Angelfire
Angelfire committed Jun 21, 2019
commit 0b2acb3970e1b34355569e3c46c9b14e4e7a9780
12 changes: 6 additions & 6 deletions test/parallel/test-buffer-failed-alloc-typed-arrays.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
'use strict';
"use strict";

require('../common');
const assert = require('assert');
const SlowBuffer = require('buffer').SlowBuffer;
require("../common");
const assert = require("assert");
const SlowBuffer = require("buffer").SlowBuffer;

// Test failed or zero-sized Buffer allocations not affecting typed arrays.
// This test exists because of a regression that occurred. Because Buffer
Expand All @@ -12,7 +12,7 @@ const SlowBuffer = require('buffer').SlowBuffer;
// whether or not to zero-fill was not being reset, causing TypedArrays to
// allocate incorrectly.
const zeroArray = new Uint32Array(10).fill(0);
const sizes = [1e10, 0, 0.1, -1, 'a', undefined, null, NaN];
const sizes = [1e10, 0, 0.1, -1, "a", undefined, null, NaN];
const allocators = [
Buffer,
SlowBuffer,
Expand All @@ -23,7 +23,7 @@ const allocators = [
for (const allocator of allocators) {
for (const size of sizes) {
try {
// These allocations are known to fail. If they do,
// Some of these allocations are known to fail. If they do,
// Uint32Array should still produce a zeroed out result.
allocator(size);
} catch {
Expand Down