Skip to content

Feature/fix freebsd build #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
indutny wants to merge 8 commits into from
Closed

Feature/fix freebsd build #332

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d9977e8
deps: fix v8 build on FreeBSD
indutny Jan 13, 2015
9645fc2
cares: 0-ify AI_V4MAPPED on FreeBSD
indutny Jan 13, 2015
c731055
test: loosen timeout in spawnsync-test for FreeBSD
indutny Jan 13, 2015
36c79c7
test: fix setproctitle on FreeBSD
indutny Jan 13, 2015
4e458d7
test: disable fs-readfile-error on FreeBSD
indutny Jan 13, 2015
60a62a8
v4mapped
indutny Jan 13, 2015
22dd5a9
test-readfile
indutny Jan 13, 2015
0ac4ee3
dns: proper comment
indutny Jan 13, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
deps: fix v8 build on FreeBSD 
clang++ on FreeBSD was blaming v8 for using invalid casts from nullptr:

    reinterpret_cast from 'nullptr_t' to '...' is not allowed

Replace casts with NULL, or NULL with 0 where applicable.

fix #324
  • Loading branch information
@indutny
indutny committed Jan 13, 2015
commit d9977e8f1ff6ac64bfc7e0c0907f27ec020eff80
2 changes: 1 addition & 1 deletion deps/v8/src/base/platform/platform-freebsd.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ std::vector<OS::SharedLibraryAddress> OS::GetSharedLibraryAddresses() {
if (bytes_read < 8) break;
unsigned end = StringToLong(addr_buffer);
char buffer[MAP_LENGTH];
int bytes_read = -1;
bytes_read = -1;
do {
bytes_read++;
if (bytes_read >= MAP_LENGTH - 1)
Expand Down
2 changes: 1 addition & 1 deletion deps/v8/src/base/platform/platform-posix.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,7 @@ int OS::GetCurrentThreadId() {
#elif V8_OS_ANDROID
return static_cast<int>(gettid());
#else
return static_cast<int>(pthread_self());
return static_cast<int>(reinterpret_cast<intptr_t>(pthread_self()));
#endif
}

Expand Down
2 changes: 1 addition & 1 deletion deps/v8/src/debug.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -573,7 +573,7 @@ void Debug::ThreadInit() {
thread_local_.step_out_fp_ = 0;
// TODO(isolates): frames_are_dropped_?
base::NoBarrier_Store(&thread_local_.current_debug_scope_,
static_cast<base::AtomicWord>(NULL));
static_cast<base::AtomicWord>(0));
thread_local_.restarter_frame_function_pointer_ = NULL;
}

Expand Down
2 changes: 1 addition & 1 deletion deps/v8/src/preparser.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -467,7 +467,7 @@ class ParserBase : public Traits {
void ReportMessageAt(Scanner::Location location, const char* message,
bool is_reference_error = false) {
Traits::ReportMessageAt(location, message,
reinterpret_cast<const char*>(NULL),
reinterpret_cast<const char*>(0),
is_reference_error);
}

Expand Down
2 changes: 1 addition & 1 deletion deps/v8/src/unique.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ class Unique {

// TODO(titzer): this is a hack to migrate to Unique<T> incrementally.
static Unique<T> CreateUninitialized(Handle<T> handle) {
return Unique<T>(reinterpret_cast<Address>(NULL), handle);
return Unique<T>(NULL, handle);
}

static Unique<T> CreateImmovable(Handle<T> handle) {
Expand Down