Skip to content

util: restrict custom inspect function + vm.Context interaction #33690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 4 commits into from
Closed

util: restrict custom inspect function + vm.Context interaction #33690

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b5bd87c
util: restrict custom inspect function + vm.Context interaction
addaleax Jun 1, 2020
583c1bd
fixup! util: restrict custom inspect function + vm.Context interaction
addaleax Jun 1, 2020
8544be7
fixup! util: restrict custom inspect function + vm.Context interaction
addaleax Jun 6, 2020
7b0b27b
fixup! fixup! util: restrict custom inspect function + vm.Context int…
addaleax Jun 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! fixup! util: restrict custom inspect function + vm.Context int… 
…eraction
  • Loading branch information
@addaleax
addaleax committed Jun 8, 2020
commit 7b0b27bac2ab5e8ca3831def6d76cd2189924836
2 changes: 1 addition & 1 deletion test/parallel/test-util-inspect.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2938,7 +2938,7 @@ assert.strictEqual(
return {};
})
});
assert.strictEqual(output, '🐈');
assert.strictEqual(output, '[object Object]');
assert.strictEqual(typeof target.ctx, 'object');
const objectGraph = fullObjectGraph(target);
assert(!objectGraph.has(Object));
Expand Down