Skip to content

doc: add updating expected assets to release guide #40470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
richardlau wants to merge 2 commits into from
Closed

doc: add updating expected assets to release guide #40470

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc4e097
doc: add updating expected assets to release guide
richardlau Oct 15, 2021
48e5404
fixup! doc: add updating expected assets to release guide
richardlau Oct 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
doc: add updating expected assets to release guide 
Add a section to the Major Releases section of the release guide
to cover updating the list of expected files for the promotion tool.
  • Loading branch information
@richardlau
richardlau committed Oct 15, 2021
commit cc4e097181663e130aa719f1c3e6ad9e8faa21f6
11 changes: 11 additions & 0 deletions doc/guides/releases.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -900,6 +900,15 @@ test, or doc-related are to be listed as notable changes. Some SEMVER-MINOR
commits may be listed as notable changes on a case-by-case basis. Use your
judgment there.

### Update the expected assets

The promotion script does a basic check that the expected files are present.
Open a pull request in the Build repository to add the list of expected files
for the new release line as a new file, `v{N}.x` (where `{N}` is the major
version of the release), in the [expected assets][] folder. The change will
need to be deployed onto the web server by a member of the [build-infra team][]
before the release is promoted.

### Snap

The Node.js [Snap][] package has a "default" for installs where the user hasn't
Expand All @@ -914,5 +923,7 @@ take place once a new LTS line has been released.
[Node.js Snap management repository]: https://github.com/nodejs/snap
[Partner Communities]: https://github.com/nodejs/community-committee/blob/HEAD/governance/PARTNER_COMMUNITIES.md
[Snap]: https://snapcraft.io/node
[build-infra team]: https://github.com/orgs/nodejs/teams/build-infra
[expected assets]: https://github.com/nodejs/build/tree/HEAD/ansible/www-standalone/tools/promote/expected_assets
[nodejs.org release-post.js script]: https://github.com/nodejs/nodejs.org/blob/HEAD/scripts/release-post.js
[nodejs.org repository]: https://github.com/nodejs/nodejs.org