Skip to content

fs: add trailing commas #43127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 18, 2022
Merged

fs: add trailing commas #43127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fs: add trailing commas 
PR-URL: #43127
Co-authored-by: Antoine du Hamel <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
  • Loading branch information
@LiviaMedeiros @aduh95
LiviaMedeiros and aduh95 committed May 18, 2022
commit fe027da1f0aa8d63ed9a2c8298a45946bc674fff
2 changes: 1 addition & 1 deletion lib/fs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -897,7 +897,7 @@ function writeSync(fd, buffer, offsetOrOptions, length, position) {
({
offset = 0,
length = buffer.byteLength - offset,
position = null
position = null,
} = offsetOrOptions ?? ObjectCreate(null));
}
if (position === undefined)
Expand Down
6 changes: 3 additions & 3 deletions lib/internal/fs/promises.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -516,7 +516,7 @@ async function read(handle, bufferOrParams, offset, length, position) {
buffer = Buffer.alloc(16384),
offset = 0,
length = buffer.byteLength - offset,
position = null
position = null,
} = bufferOrParams ?? ObjectCreate(null));

validateBuffer(buffer);
Expand All @@ -527,7 +527,7 @@ async function read(handle, bufferOrParams, offset, length, position) {
({
offset = 0,
length = buffer.byteLength - offset,
position = null
position = null,
} = offset);
}

Expand Down Expand Up @@ -579,7 +579,7 @@ async function write(handle, buffer, offsetOrOptions, length, position) {
({
offset = 0,
length = buffer.byteLength - offset,
position = null
position = null,
} = offsetOrOptions ?? ObjectCreate(null));
}

Expand Down