quic: address review feedback

src/quic/bindingdata.cc

@@ -142,7 +142,7 @@ QUIC_JS_CALLBACKS(V)
 void BindingData::SetCallbacks(const FunctionCallbackInfo<Value>& args) {
   auto env = Environment::GetCurrent(args);
   auto isolate = env->isolate();
-  BindingData& state = BindingData::Get(env);
+  auto& state = BindingData::Get(env);
   CHECK(args[0]->IsObject());
   Local<Object> obj = args[0].As<Object>();
 
@@ -161,10 +161,9 @@ void BindingData::SetCallbacks(const FunctionCallbackInfo<Value>& args) {
 #undef V
 }
 
-void BindingData::FlushPacketFreelist(
-    const v8::FunctionCallbackInfo<v8::Value>& args) {
+void BindingData::FlushPacketFreelist(const FunctionCallbackInfo<Value>& args) {
   auto env = Environment::GetCurrent(args);
-  BindingData& state = BindingData::Get(env);
+  auto& state = BindingData::Get(env);
   state.packet_freelist.clear();
 }
 

src/quic/defs.h

@@ -66,7 +66,7 @@ bool SetOption(Environment* env,
   return true;
 }
 
-// Utilities used to update that stats for Endpoint, Session, and Stream
+// Utilities used to update the stats for Endpoint, Session, and Stream
 // objects. The stats themselves are maintained in an AliasedStruct within
 // each of the relevant classes.
 

src/quic/packet.cc

@@ -43,7 +43,7 @@ struct Packet::Data final : public MemoryRetainer {
   SET_MEMORY_INFO_NAME(Data)
   SET_SELF_SIZE(Data)
 
-  Data(size_t length, const char* diagnostic_label)
+  Data(size_t length, std::string_view diagnostic_label)
       : diagnostic_label_(diagnostic_label) {
     data_.AllocateSufficientStorage(length);
   };