Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
147 commits
Select commit Hold shift + click to select a range
ba9ec91
deps: update undici to 5.21.1
nodejs-github-bot Apr 11, 2023
adc1601
src: slim down stream_base-inl.h
lilsweetcaligula Apr 11, 2023
cda36bf
src: use correct variable in node_builtins.cc
targos Apr 11, 2023
537c17e
doc: create maintaining-brotli.md
marco-ippolito Apr 3, 2023
2e83381
tools: move update-undici.sh to dep_updaters and create maintain md
marco-ippolito Apr 3, 2023
9d30f46
doc: add KhafraDev to collaborators
KhafraDev Apr 11, 2023
202042e
bootstrap: support namespaced builtins in snapshot scripts
joyeecheung Apr 11, 2023
8d43689
meta: add mailmap entry for KhafraDev
Trott Apr 11, 2023
2b411f4
stream: preserve object mode in compose
rluvaton Apr 5, 2023
2664536
deps: V8: cherry-pick 8e10685ff918
gengjiawen Apr 11, 2023
75c1d1b
wasi: make returnOnExit true by default
mhdawson Apr 3, 2023
e4d9585
tools: automate ngtcp2 and nghttp3 update
marco-ippolito Apr 12, 2023
4046280
doc: fix typo in util.types.isNativeError()
brodo Apr 12, 2023
64b5a5f
deps: update simdutf to 3.2.8
nodejs-github-bot Apr 13, 2023
ede69d2
deps: update undici to 5.21.2
nodejs-github-bot Apr 13, 2023
4839fc4
url: validate argument length in canParse
KhafraDev Apr 11, 2023
180d365
url: validate URL constructor arg length
KhafraDev Apr 11, 2023
233b628
tools: add missing pinned dependencies
mateonunez Apr 13, 2023
9e3e0b0
tools: automate uvwasi dependency update
Ranieri93 Apr 13, 2023
936d7cb
benchmark: add a benchmark for `defaultResolve`
aduh95 Apr 13, 2023
0dc5080
doc: fix split infinitive in Hooks caveat
JakobJingleheimer Apr 13, 2023
40324a1
benchmark: differentiate whatwg and legacy url
anonrig Apr 13, 2023
826f404
test: mark test-cluster-primary-error flaky on asan
anonrig Apr 14, 2023
af227b1
readline: fix issue with newline-less last line
harrisi Apr 14, 2023
e8bc03b
lib: use webidl DOMString converter in EventTarget
KhafraDev Apr 14, 2023
9aae767
url: handle URL.canParse without base parameter
anonrig Apr 14, 2023
f9abd59
doc: update darwin-x64 toolchain used for Node.js 20 releases
targos Apr 14, 2023
7ca416a
doc: add missing setEncoding call in ESM example
addaleax Apr 14, 2023
78c0824
build: replace Python linter flake8 with ruff
cclauss Apr 14, 2023
b0b16ee
doc: add link for news from uvwasi team
mhdawson Apr 14, 2023
889add6
esm: avoid try/catch when validating urls
anonrig Apr 15, 2023
269482f
esm: avoid accessing lazy getters for urls
anonrig Apr 15, 2023
ff73c05
tools: add performance label to benchmark changes
anonrig Apr 13, 2023
6af7f1e
tools: add url and whatwg-url labels automatically
anonrig Apr 13, 2023
35e8b3b
build: bump ossf/scorecard-action from 2.1.2 to 2.1.3
dependabot[bot] Apr 15, 2023
57e7ed7
src: fix CSPRNG when length exceeds INT_MAX
tniessen Apr 15, 2023
daf0c78
src: replace static const string_view by static constexpr
lemire Apr 15, 2023
4203057
test_runner: fix spec skip detection
MoLow Apr 16, 2023
ba255ed
src: fix typo in process.env accessor error message
moritzraho Apr 16, 2023
cf48db0
src: use v8::Boolean(b) over b ? True() : False()
tniessen Apr 16, 2023
8712eaf
typings: fix syntax error in tsconfig
VoltrexKeyva Apr 16, 2023
13105c1
deps: patch V8 to 11.3.244.8
targos Apr 17, 2023
7f7735c
deps: update ICU to 73.1 release
srl295 Apr 13, 2023
420feb4
crypto: remove INT_MAX restriction in randomBytes
tniessen Apr 17, 2023
2a0bbe7
doc: fix typo in webcrypto metadata
tniessen Apr 17, 2023
d3fadd8
doc: fix release-post script location
RafaelGSS Apr 17, 2023
e8ea834
quic: add more QUIC implementation
jasnell Apr 1, 2023
12f0fa3
node-api: remove unused mark_arraybuffer_as_untransferable
legendecas Apr 14, 2023
ec24aba
test_runner: avoid reporting parents of failing tests in summary
MoLow Apr 18, 2023
c36634e
doc: fix history ordering of `WASI` constructor
aduh95 Apr 18, 2023
b58920c
doc: remove markdown link from heading
tniessen Apr 18, 2023
bdd02a4
test_runner: execute before hook on test
atlowChemi Apr 18, 2023
55f70f6
esm: propagate `process.exit` from the loader thread to the main thread
aduh95 Apr 19, 2023
1509312
tools: automate zlib update
marco-ippolito Apr 19, 2023
7c552e6
tools: add option to run workflow with specific tool id
targos Apr 19, 2023
e3f4ff4
tools: add update script for googletest
tniessen Apr 19, 2023
d11ff4b
doc: improve fs permissions description
tniessen Apr 19, 2023
3154543
deps: update ada to 2.1.0
nodejs-github-bot Apr 19, 2023
c150976
esm: initialize `import.meta` on eval
aduh95 Apr 19, 2023
fbe7d73
tools: add execution permission to uvwasi script
mertcanaltin Apr 19, 2023
fbb6b72
esm: remove support for deprecated hooks
aduh95 Apr 19, 2023
568256d
node-api: test passing NULL to number APIs
gabrielschulhof Apr 20, 2023
cfafe43
src: make AliasedBuffers in the binding data weak
joyeecheung Apr 20, 2023
a54e898
fs: add support for mode flag to specify the copy behavior
tetsuharuohzeki Apr 20, 2023
c17f268
Revert "tools: ensure failed daily wpt run still generates a report"
panva Apr 19, 2023
9d3768e
Revert "test: run WPT files in parallel again"
panva Apr 19, 2023
183f0c3
doc: change offset of example in `Buffer.copyBytesFrom`
deokjinkim Apr 20, 2023
87cae0c
tools: update PR label config
VoltrexKeyva Apr 20, 2023
94a5abb
inspector: add tips for Session
theanarkh Apr 20, 2023
872e670
src: add v8 fast api for url canParse
KhafraDev Apr 20, 2023
439ea47
fs: add recursive option to readdir and opendir
Apr 20, 2023
1391d3b
deps: add minimatch as a dependency
MoLow Apr 8, 2023
b8927dd
tools: fix updating root certificates
richardlau Apr 21, 2023
9101630
doc: update error code of buffer
deokjinkim Apr 21, 2023
91e4a7c
loader: use default loader as cascaded loader in the in loader worker
joyeecheung Apr 21, 2023
0887fa0
tools: keep PR titles/description up-to-date
tniessen Apr 21, 2023
b8bdaf8
lib: disallow file-backed blob cloning
jasnell Apr 15, 2023
5b851c8
build: add devcontainer configuration
bnb Nov 15, 2021
09ff9ea
doc,fs: update description of fs.stat() method
mertcanaltin Apr 23, 2023
78a3503
doc: fix typos in SECURITY.md
VoltrexKeyva Apr 23, 2023
ccf9c37
tools: update lint-md-dependencies to @rollup/[email protected]
nodejs-github-bot Apr 23, 2023
1f120a3
test_runner: move coverage collection to root.postRun()
cjihrig Apr 23, 2023
b6fb791
test_runner: support coverage of unnamed functions
cjihrig Apr 23, 2023
f30ef24
doc: fix capitalization of ASan
VoltrexKeyva Apr 23, 2023
2d97c89
crypto: update root certificates to NSS 3.89
nodejs-github-bot Apr 23, 2023
5327483
test_runner: add testNamePatterns to run api
atlowChemi Apr 19, 2023
4cef988
doc: fix typos
VoltrexKeyva Apr 23, 2023
5a9b71a
test_runner: fix nested hooks
MoLow Apr 23, 2023
21ff331
lib: improve esm resolve performance
anonrig Apr 23, 2023
4fa7739
http: add highWaterMark opt in http.createServer
HinataKah0 Apr 24, 2023
c0c23fb
doc: fix a typo in `fs.openAsBlob`
daeyeon Apr 24, 2023
a793cf4
esm: rename `URLCanParse` to be consistent
aduh95 Apr 22, 2023
a1403a8
doc: clarify concurrency model of test runner
tniessen Apr 24, 2023
d2994e5
tools: fix skip message in update-cjs-module-lexer
tniessen Apr 24, 2023
2d7cac0
test_runner: fix test counting
MoLow Apr 24, 2023
40b3879
test_runner: fix test runner concurrency
MoLow Apr 22, 2023
f3ee312
deps: update ada to 2.2.0
nodejs-github-bot Apr 25, 2023
9962459
deps: update undici to 5.22.0
nodejs-github-bot Apr 25, 2023
bf9a52c
src: prevent changing FunctionTemplateInfo after publish
codebytere Apr 25, 2023
84fa9fd
test: refactor WPTRunner and enable parallel WPT execution
panva Apr 25, 2023
f8581e7
test_runner: remove no-op validation
cjihrig Apr 25, 2023
4431df7
src: split BlobSerializer/BlobDeserializer
joyeecheung Apr 7, 2023
c5c40a8
doc: async_hooks asynchronous content example add mjs code
btea Apr 26, 2023
4d02901
node-api: test passing NULL to napi_define_class
gabrielschulhof Apr 26, 2023
57c6998
tls: accept SecureContext object in server.addContext()
HinataKah0 Apr 26, 2023
63e8c95
tools: automate v8 patch update
marco-ippolito Apr 26, 2023
ce8820e
dns: expose getDefaultResultOrder
btea Apr 26, 2023
9d0bef6
tools: fix update-v8-patch cache
marco-ippolito Apr 26, 2023
226e5b8
tools: move update-npm to dep updaters
marco-ippolito Apr 26, 2023
5709133
doc: fix a typo in `permissions.md`
daeyeon Apr 26, 2023
d08dd80
deps: update ada to 2.3.0
nodejs-github-bot Apr 27, 2023
f88132f
stream: prevent pipeline hang with generator functions
debadree25 Apr 27, 2023
2acb57b
src: mark fatal error functions as noreturn
legendecas Apr 27, 2023
5bb7b26
test: remove spaces from test runner test names
tniessen Apr 27, 2023
20b0de2
doc: add link to news for Node.js core
mhdawson Apr 27, 2023
1f9e7ce
src: fix typo in comment in quic/sessionticket.cc
tniessen Apr 28, 2023
26bccbc
doc: move addaleax to TSC emeriti
addaleax Apr 27, 2023
b954ea9
doc: mark signing the binary is macOS and Windows only in SEA
meixg Apr 28, 2023
6ee5e42
test_runner: support combining coverage reports
cjihrig Apr 28, 2023
185d609
doc,test: fix concurrency option of test()
tniessen Apr 28, 2023
dc43ce7
src: replace idna functions with ada::idna
anonrig Apr 28, 2023
00d461e
deps: V8: cherry-pick c5ab3e4f0c5a
richardlau Apr 28, 2023
ceba37a
doc: move BethGriggs to regular member
Trott Apr 28, 2023
d750364
doc: fix typo in webstreams.md
christiantakle Apr 28, 2023
33d1bd3
assert: deprecate callTracker
MoLow Apr 29, 2023
e948bec
src: avoid copying string in fs_permission
anonrig Apr 29, 2023
606523d
v8: fix ERR_NOT_BUILDING_SNAPSHOT is not a constructor
legendecas Apr 29, 2023
e5251e3
test_runner: fix --require with --experimental-loader
MoLow Apr 29, 2023
8d1588a
tools: update lint-md-dependencies to [email protected]
nodejs-github-bot Apr 30, 2023
e4b6b79
url: reduce revokeObjectURL cpp calls
anonrig Apr 30, 2023
9279440
meta: ping nodejs/startup for startup test changes
joyeecheung Apr 30, 2023
98450d9
doc: remove MoLow from Triagers
MoLow Apr 30, 2023
6d87355
benchmark: add eventtarget creation bench
RafaelGSS Apr 30, 2023
089c9c5
build: refactor configure.py
VoltrexKeyva May 1, 2023
6046779
deps: disable V8 concurrent sparkplug compilation
targos Apr 6, 2023
326c3f1
tools: add the missing LoongArch64 definition in the v8.gyp file
sunhaiyong1978 Apr 20, 2023
3befe5d
doc: add copy node executable guide on windows
yjl9903 Apr 22, 2023
97a3d39
test: add and use tmpdir.hasEnoughSpace()
tniessen May 1, 2023
98603b6
doc: clarify fs permissions only affect fs module
tniessen May 1, 2023
aa0ef3e
doc: fix --allow-* CLI flag references
tniessen May 1, 2023
c620eb8
tools: update doc to [email protected]
nodejs-github-bot May 2, 2023
d5089fe
meta: fix dependabot commit message
Mesteery May 2, 2023
4c26e28
doc: create maintaining folder for deps
marco-ippolito May 2, 2023
30af5ce
build: use pathlib for paths
VoltrexKeyva May 2, 2023
96f93cc
http: remove internal error in assignSocket
mcollina May 2, 2023
159cf02
test: refactor to use `getEventListeners` in timers
deokjinkim May 3, 2023
68ef4a6
2023-05-03, Version 20.1.0 (Current)
targos May 2, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
doc: fix typos
PR-URL: #47685
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Daeyeon Jeong <[email protected]>
  • Loading branch information
VoltrexKeyva authored and targos committed May 2, 2023
commit 4cef98812df5e5b74bea7b32a3863cd0baeba924
2 changes: 1 addition & 1 deletion doc/api/cli.md
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,7 @@ the path specified by `--snapshot-blob`.
```console
$ echo "globalThis.foo = 'I am from the snapshot'" > snapshot.js

# Run snapshot.js to intialize the application and snapshot the
# Run snapshot.js to initialize the application and snapshot the
# state of it into snapshot.blob.
$ node --snapshot-blob snapshot.blob --build-snapshot snapshot.js

Expand Down
4 changes: 2 additions & 2 deletions doc/api/diagnostics_channel.md
Original file line number Diff line number Diff line change
Expand Up @@ -567,7 +567,7 @@ applied to transform the message data before it becomes the context value for
the store. The prior storage context is accessible from within the transform
function in cases where context linking is required.

The context applied to the store should be accesible in any async code which
The context applied to the store should be accessible in any async code which
continues from execution which began during the given function, however
there are some situations in which [context loss][] may occur.

Expand Down Expand Up @@ -956,7 +956,7 @@ channels.asyncStart.bindStore(myStore, (data) => {

A TracingChannel is a collection of several diagnostics\_channels representing
specific points in the execution lifecycle of a single traceable action. The
behaviour is split into five diagnostics\_channels consisting of `start`,
behavior is split into five diagnostics\_channels consisting of `start`,
`end`, `asyncStart`, `asyncEnd`, and `error`. A single traceable action will
share the same event object between all events, this can be helpful for
managing correlation through a weakmap.
Expand Down
4 changes: 2 additions & 2 deletions doc/api/domain.md
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ If domains are in use, then all **new** `EventEmitter` objects (including
Stream objects, requests, responses, etc.) will be implicitly bound to
the active domain at the time of their creation.

Additionally, callbacks passed to lowlevel event loop requests (such as
Additionally, callbacks passed to low-level event loop requests (such as
to `fs.open()`, or other callback-taking methods) will automatically be
bound to the active domain. If they throw, then the domain will catch
the error.
Expand Down Expand Up @@ -409,7 +409,7 @@ specified emitter.
* `...args` {any}

Run the supplied function in the context of the domain, implicitly
binding all event emitters, timers, and lowlevel requests that are
binding all event emitters, timers, and low-level requests that are
created in that context. Optionally, arguments can be passed to
the function.

Expand Down
4 changes: 2 additions & 2 deletions doc/api/inspector.md
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ Create a new instance of the `inspector.Session` class. The inspector session
needs to be connected through [`session.connect()`][] before the messages
can be dispatched to the inspector backend.

When using `Session`, the object outputed by the console API will not be
When using `Session`, the object outputted by the console API will not be
released, unless we performed manually `Runtime.DiscardConsoleEntries`
command.

Expand Down Expand Up @@ -227,7 +227,7 @@ Create a new instance of the `inspector.Session` class. The inspector session
needs to be connected through [`session.connect()`][] before the messages
can be dispatched to the inspector backend.

When using `Session`, the object outputed by the console API will not be
When using `Session`, the object outputted by the console API will not be
released, unless we performed manually `Runtime.DiscardConsoleEntries`
command.

Expand Down
4 changes: 2 additions & 2 deletions doc/api/n-api.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ Node-API is a C API that ensures ABI stability across Node.js versions
and different compiler levels. A C++ API can be easier to use.
To support using C++, the project maintains a
C++ wrapper module called [`node-addon-api`][].
This wrapper provides an inlineable C++ API. Binaries built
This wrapper provides an inlinable C++ API. Binaries built
with `node-addon-api` will depend on the symbols for the Node-API C-based
functions exported by Node.js. `node-addon-api` is a more
efficient way to write code that calls Node-API. Take, for example, the
Expand Down Expand Up @@ -542,7 +542,7 @@ the call will succeed and `data` will be set to `NULL`.

## Basic Node-API data types

Node-API exposes the following fundamental datatypes as abstractions that are
Node-API exposes the following fundamental data types as abstractions that are
consumed by the various APIs. These APIs should be treated as opaque,
introspectable only with other Node-API calls.

Expand Down
2 changes: 1 addition & 1 deletion doc/api/util.md
Original file line number Diff line number Diff line change
Expand Up @@ -1481,7 +1481,7 @@ console.log(values, positionals);

### `parseArgs` `tokens`

Detailed parse information is available for adding custom behaviours by
Detailed parse information is available for adding custom behaviors by
specifying `tokens: true` in the configuration.
The returned tokens have properties describing:

Expand Down
2 changes: 1 addition & 1 deletion doc/api/wasi.md
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ changes:
the real paths to those directories on the host machine.
* `returnOnExit` {boolean} By default, when WASI applications call
`__wasi_proc_exit()` `wasi.start()` will return with the exit code
specified rather than terminatng the process. Setting this option to
specified rather than terminating the process. Setting this option to
`false` will cause the Node.js process to exit with the specified
exit code instead. **Default:** `true`.
* `stdin` {integer} The file descriptor used as standard input in the
Expand Down
2 changes: 1 addition & 1 deletion doc/api/worker_threads.md
Original file line number Diff line number Diff line change
Expand Up @@ -1009,7 +1009,7 @@ changes:
* `stackSizeMb` {number} The default maximum stack size for the thread.
Small values may lead to unusable Worker instances. **Default:** `4`.
* `name` {string} An optional `name` to be appended to the worker title
for debuggin/identification purposes, making the final title as
for debugging/identification purposes, making the final title as
`[worker ${id}] ${name}`. **Default:** `''`.

### Event: `'error'`
Expand Down
2 changes: 1 addition & 1 deletion doc/contributing/adding-v8-fast-api.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
Node.js uses [V8](https://v8.dev/) as its JavaScript engine.
Embedding functions implemented in C++ incur a high overhead, so V8
provides an API to implement native functions which may be invoked directly
from JITted code. These functions also come with additional constraints,
from JIT-ed code. These functions also come with additional constraints,
for example, they may not trigger garbage collection.

## Limitations
Expand Down
4 changes: 2 additions & 2 deletions doc/contributing/api-documentation.md
Original file line number Diff line number Diff line change
Expand Up @@ -251,8 +251,8 @@ the new tooling.
This method is responsible for parsing the `<--YAML snippets -->` and
transforming them into HTML elements.

It follows a certain kind of "schema" that basically constitues in the following
options:
It follows a certain kind of "schema" that basically constitutes in the
following options:

| YAML Key | Description | Example | Example Result | Available on new tooling |
| ------------- | ------------------------------------------------------------------------------------------------------------------------------- | ----------------------------------------------------- | --------------------------- | ------------------------ |
Expand Down
4 changes: 2 additions & 2 deletions doc/contributing/investigating-native-memory-leaks.md
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ with the output being:
user1@minikube1:~/valgrind/node-addon-examples/1_hello_world/napi$ valgrind node test.js
==28993== Memcheck, a memory error detector
==28993== Copyright (C) 2002-2017, and GNU GPL'd, by Julian Seward et al.
==28993== Using valgrind-3.13.0 and LibVEX; rerun with -h for copyright info
==28993== Using Valgrind-3.13.0 and LibVEX; rerun with -h for copyright info
==28993== Command: node test.js
==28993==
==28993== Use of uninitialised value of size 8
Expand Down Expand Up @@ -139,7 +139,7 @@ Running Valgrind on this code shows the following:
user1@minikube1:~/valgrind/node-addon-examples/1_hello_world/napi$ valgrind node hello.js
==1504== Memcheck, a memory error detector
==1504== Copyright (C) 2002-2017, and GNU GPL'd, by Julian Seward et al.
==1504== Using V#algrind-3.13.0 and LibVEX; rerun with -h for copyright info
==1504== Using Valgrind-3.13.0 and LibVEX; rerun with -h for copyright info
==1504== Command: node hello.js
==1504==
==1504== Use of uninitialised value of size 8
Expand Down
2 changes: 1 addition & 1 deletion doc/contributing/maintaining-cjs-module-lexer.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ inclusion in the `deps_files` entry in
The two different versions of lexer.js are maintained in the
[nodejs/cjs-module-lexer][] project.

In order to update the Node.js dependencies to use to a newer verion
In order to update the Node.js dependencies to use to a newer version
of cjs-module-lexer, complete the following steps:

* Clone [nodejs/cjs-module-lexer][]
Expand Down
4 changes: 2 additions & 2 deletions doc/contributing/maintaining-dependencies.md
Original file line number Diff line number Diff line change
Expand Up @@ -90,12 +90,12 @@ can be added by:
the new option by running `./configure --help`.

* adding a call to `AddExternalizedBuiltin` to the constructor
for BuildinLoader in `src/node_builtins.cc` for the
for BuiltinLoader in `src/node_builtins.cc` for the
dependency using the `NODE_SHARED_BUILTLIN` #define generated for
the dependency. After running `./configure` with the new
option you can find the #define in `config.gypi`. You can cut and
paste one of the existing entries and then update to match the
inport name for the dependency and the #define generated.
import name for the dependency and the #define generated.

## Supporting non-externalized dependencies with JavaScript code

Expand Down
2 changes: 1 addition & 1 deletion doc/contributing/maintaining-types-for-nodejs.md
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ Some additional specifics around the current approach include:
the ability to provide different configurations for user-defined
conditions.
* There is no plan to define a default tsconfig.json for all Node.js users
* We don't have consensus on provding an opinionated default but
* We don't have consensus on providing an opinionated default but
that should be explored after the initial steps are complete.
* It will be important that as part of the messaging around this
functionality that we avoid confusion that could lead people to ship
Expand Down
8 changes: 4 additions & 4 deletions doc/contributing/releases.md
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ $ git push upstream v1.x-staging
<summary>Security release</summary>

Security releases with private patches need to be prepared in the `nodejs-private`
GitHub organisation.
GitHub organization.

Add the `nodejs-private` remote:

Expand All @@ -252,7 +252,7 @@ The list of patches to include should be listed in the "Next Security Release"
issue in `nodejs-private`. Ask the security release steward if you're unsure.

The `git node land` tool does not work with the `nodejs-private`
organisation. To land a PR in Node.js private, use `git cherry-pick` to apply
organization. To land a PR in Node.js private, use `git cherry-pick` to apply
each commit from the PR. You will also need to manually apply the PR
metadata (`PR-URL`, `Reviewed-by`, etc.) by amending the commit messages. If
known, additionally include `CVE-ID: CVE-XXXX-XXXXX` in the commit metadata.
Expand Down Expand Up @@ -373,7 +373,7 @@ all.

For security releases, it is necessary to include more detailed information
including which vulnerabilities have been fixed, and any revert flags or
workarounds to revert to the old behaviour.
workarounds to revert to the old behavior.

You can use the following template as a guide:

Expand Down Expand Up @@ -751,7 +751,7 @@ $ git push upstream v1.x-staging
<summary>Security release</summary>

For security releases, you can start merging the release in the `nodejs-private`
GitHub organisation in advance by following the same steps:
GitHub organization in advance by following the same steps:

```console
$ git checkout v1.x
Expand Down
2 changes: 1 addition & 1 deletion doc/contributing/writing-and-running-benchmarks.md
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,7 @@ module, you can use the `--filter` option:_
--no-progress don't show benchmark progress indicator
```

For analysing the benchmark results, use [node-benchmark-compare][] or the R
For analyzing the benchmark results, use [node-benchmark-compare][] or the R
script `benchmark/compare.R`.

```console
Expand Down