Skip to content

fs: runtime deprecate fs.F_OK, fs.R_OK, fs.W_OK, fs.X_OK #49686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 14, 2024
Merged

fs: runtime deprecate fs.F_OK, fs.R_OK, fs.W_OK, fs.X_OK #49686

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d5b465c
fs: runtime deprecate `fs.F_OK`, `fs.R_OK`, `fs.W_OK`, `fs.X_OK`
LiviaMedeiros Sep 17, 2023
5369c71
squash: fix DEP number
LiviaMedeiros Nov 3, 2024
5d01b37
squash: add test
LiviaMedeiros Nov 5, 2024
37546ec
squash: adjust test
LiviaMedeiros Nov 5, 2024
7000c66
squash: lint
LiviaMedeiros Nov 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
squash: lint
  • Loading branch information
@LiviaMedeiros
LiviaMedeiros committed Nov 5, 2024
commit 7000c66039c77eae7663b1bf68b529b5aaef9e4c
8 changes: 4 additions & 4 deletions test/parallel/test-fs-constants.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,10 @@ assert.notStrictEqual(fs.constants.S_IWUSR, undefined);
// Check for runtime deprecation warning, there should be no setter
const { F_OK, R_OK, W_OK, X_OK } = fs.constants;

assert.throws(() => { fs.F_OK = 'overwritten' }, { name: 'TypeError' });
assert.throws(() => { fs.R_OK = 'overwritten' }, { name: 'TypeError' });
assert.throws(() => { fs.W_OK = 'overwritten' }, { name: 'TypeError' });
assert.throws(() => { fs.X_OK = 'overwritten' }, { name: 'TypeError' });
assert.throws(() => { fs.F_OK = 'overwritten'; }, { name: 'TypeError' });
assert.throws(() => { fs.R_OK = 'overwritten'; }, { name: 'TypeError' });
assert.throws(() => { fs.W_OK = 'overwritten'; }, { name: 'TypeError' });
assert.throws(() => { fs.X_OK = 'overwritten'; }, { name: 'TypeError' });

expectWarning(
'DeprecationWarning',
Expand Down
Loading