Skip to content

deps: update V8 to 13.0 #55014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 18 commits into from
Closed

deps: update V8 to 13.0 #55014

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
6d2440f
deps: update V8 to 13.0.245.25
targos Jan 30, 2025
63794a5
build: reset embedder string to "-node.0"
targos Jan 30, 2025
d7ea9aa
src: update NODE_MODULE_VERSION to 134
targos Jan 30, 2025
9c8e1b8
deps: always define V8_EXPORT_PRIVATE as no-op
targos Sep 21, 2022
40dc118
deps: disable V8 concurrent sparkplug compilation
targos Apr 6, 2023
ff8ae43
deps: patch V8 to avoid duplicated zlib symbol
targos Sep 16, 2023
5ebad88
deps: patch V8 to support compilation with MSVC
StefanStojanovic Apr 21, 2024
5cfb430
deps: fix FP16 bitcasts.h
StefanStojanovic May 28, 2024
a0ee31a
deps: always define V8_NODISCARD as no-op
targos Aug 8, 2024
a4f5d74
deps: define V8_PRESERVE_MOST as no-op on Windows
StefanStojanovic Dec 16, 2024
043202c
deps: V8: cherry-pick 0c11feeeca4a
targos Sep 25, 2024
4d6d738
deps: V8: cherry-pick 0d5d6e71bbb0
anonrig Sep 20, 2024
5e894ae
deps: V8: cherry-pick f915fa4c9f41
o- Oct 21, 2024
c4673b7
tools: update V8 gypfiles for 13.0
targos Aug 24, 2024
6e1786d
build: remove support for ppc 32-bit
targos Aug 24, 2024
8253b27
src: update GetForegroundTaskRunner override
etiennep-chromium Aug 28, 2024
740c7b7
build: link V8 with atomic library
targos Sep 19, 2024
63ee9f0
test: disable fast API call count checks
targos Sep 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
deps: disable V8 concurrent sparkplug compilation 
It introduces process hangs on some platforms because Node.js doesn't
tear down V8 correctly.
Disable it while we work on a solution.

Refs: #47297
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=13902
PR-URL: #47450
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
  • Loading branch information
@targos
targos committed Jan 30, 2025
commit 40dc1189d0db485c15ba95ee0d2e1684b14b24cf
2 changes: 1 addition & 1 deletion common.gypi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.1',
'v8_embedder_string': '-node.2',

##### V8 defaults for Node.js #####

Expand Down
2 changes: 1 addition & 1 deletion deps/v8/src/flags/flag-definitions.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -989,7 +989,7 @@ DEFINE_BOOL(baseline_batch_compilation, true, "batch compile Sparkplug code")
DEFINE_BOOL_READONLY(concurrent_sparkplug, false,
"compile Sparkplug code in a background thread")
#else
DEFINE_BOOL(concurrent_sparkplug, ENABLE_SPARKPLUG_BY_DEFAULT,
DEFINE_BOOL(concurrent_sparkplug, false,
"compile Sparkplug code in a background thread")
DEFINE_WEAK_IMPLICATION(future, concurrent_sparkplug)
DEFINE_NEG_IMPLICATION(predictable, concurrent_sparkplug)
Expand Down