Skip to content

sqlite: add aggregate function #56600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 4 commits into from
Apr 9, 2025
Merged

sqlite: add aggregate function #56600

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5c151f5
sqlite,doc,test: add aggregate function
geeksilva97 Apr 4, 2025
57e6a4d
apply review suggestions
geeksilva97 Apr 6, 2025
2357291
apply review suggestion
geeksilva97 Apr 7, 2025
484d68d
fix typos
geeksilva97 Apr 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
apply review suggestion 
Co-authored-by: James M Snell <[email protected]>
  • Loading branch information
@geeksilva97 @jasnell
geeksilva97 and jasnell authored Apr 7, 2025
commit 2357291bae8c30fc55959076f32a07aae26b9cdd
2 changes: 1 addition & 1 deletion src/node_sqlite.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ inline MaybeLocal<Object> CreateSQLiteError(Isolate* isolate, sqlite3* db) {
void JSValueToSQLiteResult(Isolate* isolate,
sqlite3_context* ctx,
Local<Value> value) {
if (value->IsUndefined() || value->IsNull()) {
if (value->IsNullOrUndefined()) {
sqlite3_result_null(ctx);
} else if (value->IsNumber()) {
sqlite3_result_double(ctx, value.As<Number>()->Value());
Expand Down
Loading