Skip to content

Cherry-pick patch from V8 upstream that fixes instanceof problem #7638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fhinkel wants to merge 5 commits into from
+48 −7
Closed

Cherry-pick patch from V8 upstream that fixes instanceof problem #7638

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ca51390
deps: cherry-pick 2aa070be from V8 upstream
fhinkel Jul 8, 2016
e06e255
deps: cherry-pick 3a903c4 for PPC from V8 upstream
fhinkel Jul 11, 2016
f007c0a
deps: cherry-pick 5b5d24b for X87 from V8 upstream
fhinkel Jul 11, 2016
ef9092b
test: add regression test for instanceof
fhinkel Jul 8, 2016
8261c9f
deps: bump V8 patchlevel for instanceof cherry-picks
fhinkel Jul 11, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
deps: cherry-pick 5b5d24b for X87 from V8 upstream 
Original commit message:

    port 2aa070b (r34863)

    original commit message:
        Repair this to match what the runtime correctly does,
        by first checking if the function is a constructor
        before we access the prototype.

    BUG=

    Review URL: https://codereview.chromium.org/1809333002

    Cr-Commit-Position: refs/heads/master@{#34880}

Fixes: #7592 for X87
  • Loading branch information
@fhinkel
fhinkel committed Jul 21, 2016
commit f007c0acdc56d5bd3f0acdf73b5af7bdd75a0efb
5 changes: 5 additions & 0 deletions deps/v8/src/x87/code-stubs-x87.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1835,6 +1835,11 @@ void InstanceOfStub::Generate(MacroAssembler* masm) {
__ CmpObjectType(function, JS_FUNCTION_TYPE, function_map);
__ j(not_equal, &slow_case);

// Go to the runtime if the function is not a constructor.
__ test_b(FieldOperand(function_map, Map::kBitFieldOffset),
static_cast<uint8_t>(1 << Map::kIsConstructor));
__ j(zero, &slow_case);

// Ensure that {function} has an instance prototype.
__ test_b(FieldOperand(function_map, Map::kBitFieldOffset),
static_cast<uint8_t>(1 << Map::kHasNonInstancePrototype));
Expand Down