Skip to content

test: enable cyrillic punycode test case #8695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bnoordhuis merged 1 commit into from
Sep 23, 2016
Merged

test: enable cyrillic punycode test case #8695

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: enable cyrillic punycode test case 
The test from RFC 3492 contains a bug: the uppercase D in the input
should be lowercased.  Fix that and enable the test.

Fixes: #8691
PR-URL: #8695
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Ilkka Myller <[email protected]>
Reviewed-By: James M Snell <[email protected]>
  • Loading branch information
@bnoordhuis
bnoordhuis committed Sep 23, 2016
commit dae53238dc1aa38cbdb2dcff6c73373be1d6d071
4 changes: 1 addition & 3 deletions test/parallel/test-punycode.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,12 +62,10 @@ var tests = {
'\uC744\uAE4C',

// (I) Russian (Cyrillic)
/* XXX disabled, fails - possibly a bug in the RFC
'b1abfaaepdrnnbgefbaDotcwatmq2g4l':
'b1abfaaepdrnnbgefbadotcwatmq2g4l':
'\u043F\u043E\u0447\u0435\u043C\u0443\u0436\u0435\u043E\u043D\u0438' +
'\u043D\u0435\u0433\u043E\u0432\u043E\u0440\u044F\u0442\u043F\u043E' +
'\u0440\u0443\u0441\u0441\u043A\u0438',
*/

// (J) Spanish: Porqu<eacute>nopuedensimplementehablarenEspa<ntilde>ol
'PorqunopuedensimplementehablarenEspaol-fmd56a':
Expand Down