Skip to content

feat: show progress bar when embedding using local model#363

Merged
wilson-nomic merged 2 commits intomainfrom
feat-local-embed-pb
Dec 13, 2024
Merged

feat: show progress bar when embedding using local model#363
wilson-nomic merged 2 commits intomainfrom
feat-local-embed-pb

Conversation

@wilson-nomic
Copy link
Copy Markdown
Contributor

@wilson-nomic wilson-nomic commented Dec 10, 2024

Show a progress bar when using nomic.embed.text(..., inference_mode="local").

Resolves https://linear.app/nomic/issue/NOM-2283/tqdm-progress-bar-for-embedtext-would-be-nice.


Important

Adds a progress bar to _text_embed4all() in nomic/embed.py for local text embedding, updating with each batch processed.

  • Behavior:
    • Adds a progress bar using tqdm in _text_embed4all() in nomic/embed.py for local text embedding.
    • Progress bar updates for each batch of texts processed, providing real-time feedback.
  • Misc:
    • Resolves issue NOM-2283 regarding the addition of a progress bar for embed.text() with inference_mode="local".

This description was created by Ellipsis for d438bae. It will automatically update as commits are pushed.

@wilson-nomic wilson-nomic self-assigned this Dec 10, 2024
Copy link
Copy Markdown
Contributor

@mcembalest mcembalest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working for me locally, thank you for this. Approved and good to merge once tests are passing

@wilson-nomic wilson-nomic merged commit 98dfece into main Dec 13, 2024
@wilson-nomic wilson-nomic deleted the feat-local-embed-pb branch December 13, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants