fix: reduce upload workers to 2

[mcembalest]

Important

Reduce upload workers from 10 to 2 in _add_blobs(), _add_data(), and update_maps() in nomic/dataset.py.

• Concurrency:
  • Reduce num_workers from 10 to 2 in _add_blobs(), _add_data(), and update_maps() in nomic/dataset.py.
• Functions Affected:
  • _add_blobs(): Handles image blob uploads.
  • _add_data(): Manages low-level data uploads.
  • update_maps(): Deprecated method for updating project maps.

^{This description was created by for 42e35f0. You can customize this summary. It will automatically update as commits are pushed.}

[ellipsis-dev]

Important

Looks good to me! 👍

Reviewed everything up to ab35b93 in 57 seconds. Click for details.

• Reviewed 34 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 3 draft comments. View those below.
• Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.

1. nomic/dataset.py:1422

• Draft comment:
  Hardcoded worker count (2) is repeated. Consider defining a constant (e.g. DEFAULT_UPLOAD_WORKERS) to avoid magic numbers and ease future changes.
• Reason this comment was not posted:
  Confidence changes required: 33% <= threshold 70% None

2. nomic/dataset.py:1566

• Draft comment:
  The _add_data function now uses 2 workers instead of 10. To keep things DRY, consider using a shared constant for the upload worker count.
• Reason this comment was not posted:
  Confidence changes required: 33% <= threshold 70% None

3. nomic/dataset.py:1687

• Draft comment:
  Default parameter 'num_workers' in update_maps is reduced to 2. Consider documenting this change or using a shared constant so that all upload-related methods remain in sync.
• Reason this comment was not posted:
  Confidence changes required: 33% <= threshold 70% None

Workflow ID: wflow_evCebh1YDZeKKarQ

^{You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.}

[ellipsis-dev]

Important

Looks good to me! 👍

Reviewed 42e35f0 in 51 seconds. Click for details.

• Reviewed 17 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 1 draft comments. View those below.
• Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.

1. nomic/dataset.py:1566

• Draft comment:
  The diff removes an explanatory comment and hardcodes num_workers = 2. Consider briefly retaining a rationale for this choice or making it configurable for flexibility.
• Reason this comment was not posted:
  Confidence changes required: 33% <= threshold 70% None

Workflow ID: wflow_EMJnKcJnqMiJvDKV

^{You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.}

[bmschmidt]

LGTM