feat: add py.typed marker for PEP 561 compliance#400
Merged
cebtenzzre merged 1 commit intonomic-ai:mainfrom Nov 4, 2025
Merged
feat: add py.typed marker for PEP 561 compliance#400cebtenzzre merged 1 commit intonomic-ai:mainfrom
cebtenzzre merged 1 commit intonomic-ai:mainfrom
Conversation
Adds a py.typed marker file to enable type checking in downstream projects that use mypy or other type checkers. This allows static type checkers to recognize and use the type annotations present in the nomic package. Also adds MANIFEST.in to ensure the py.typed file is included in the distributed package. Resolves nomic-ai#312
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to cff32e4 in 31 seconds. Click for details.
- Reviewed
10lines of code in2files - Skipped
0files when reviewing. - Skipped posting
1draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. MANIFEST.in:1
- Draft comment:
MANIFEST.in correctly includes the py.typed file for PEP 561 compliance. This change meets the issue requirements. - Reason this comment was not posted:
Confidence changes required:0%<= threshold70%None
Workflow ID: wflow_aQvDdZqGGwtM9Sfm
You can customize 
cebtenzzre
approved these changes
Nov 4, 2025
Member
cebtenzzre
left a comment
cebtenzzre
left a comment
There was a problem hiding this comment.
sure, this should be a net improvement.
Member
|
Thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #312
Summary
Adds a
py.typedmarker file to enable type checking support for downstream projects using mypy, pyright, or other type checkers that follow PEP 561.Changes
py.typedfile in thenomicpackage directoryMANIFEST.into ensure the marker file is included in distributionsContext
The nomic package already has comprehensive type annotations throughout the codebase. Adding the
py.typedmarker allows type checkers in downstream projects to recognize and use these annotations, improving the development experience for users of the library.This follows the PEP 561 specification for distributing type information: https://typing.readthedocs.io/en/latest/spec/distributing.html#packaging-type-information
Important
Adds
py.typedmarker for PEP 561 compliance, enabling type checking in downstream projects.py.typedfile tonomicpackage for PEP 561 compliance, enabling type checking for downstream projects.MANIFEST.into includepy.typedin distributions.This description was created by
for cff32e4. You can customize this summary. It will automatically update as commits are pushed.