Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: npm/npm-install-checks
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v7.1.0
Choose a base ref
...
head repository: npm/npm-install-checks
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v7.1.1
Choose a head ref
  • 3 commits
  • 5 files changed
  • 4 contributors

Commits on Nov 21, 2024

  1. fix: cache local environment values (#120) 

    Yes this is a bit dirty because the report is now generated once at the
beginning of a command which could be considered a side effect (but
normally treeshaking will only include it only if needed), but the whole
process.report is a weirdly built API meant for debugging and not really
meant to be used in a normal program

But somehow when the call is done in the beginning of the process, this
call is very fast, but when it's called after having run a http request
(as is currently the case, a single call takes a lot more time to
complete, it takes 40s or more on my system when called at the end of
npm upgrade) but only a few milliseconds when called at the beginning
(this is why it's best to run it outside the function at the beginning
of the process as a side effect instead of calling getReport on demand
and cache the result)

Here is a log of console.time('report') and console.timeEnd('report')
before and after the getReport call
when run in the end of the upgrade command:
⠼report: 3:10.573 (m:ss.mmm)
when run in the beginning of the process at the top level
report: 1.943ms

This fixes npm hanging npm/cli#4028,
npm/cli#7814,
npm/cli#7868
    @Tofandel
    Tofandel authored Nov 21, 2024
    Configuration menu
    Copy the full SHA
    acf64a7 View commit details
    Browse the repository at this point in the history

  2. chore: bump @npmcli/template-oss from 4.23.3 to 4.23.4 (#119) 

    Bumps [@npmcli/template-oss](https://github.com/npm/template-oss) from
4.23.3 to 4.23.4.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/npm/template-oss/releases"><code>@​npmcli/template-oss</code>'s
releases</a>.</em></p>
<blockquote>
<h2>v4.23.4</h2>
<h2><a
href="https://github.com/npm/template-oss/compare/v4.23.3...v4.23.4">4.23.4</a>
(2024-10-02)</h2>
<h3>Dependencies</h3>
<ul>
<li><a
href="https://github.com/npm/template-oss/commit/d267eb37f516cace03d8d30fbaf20a91d8525005"><code>d267eb3</code></a>
<a href="https://github.com/npm/template-oss/pull/487">#487</a>
bump <code>[email protected]</code></li>
<li><a
href="https://github.com/npm/template-oss/commit/1d3b53e5a0a35dbf15303f2d19008e0e23c431b3"><code>1d3b53e</code></a>
<a href="https://github.com/npm/template-oss/pull/487">#487</a>
bump <code>[email protected]</code></li>
<li><a
href="https://github.com/npm/template-oss/commit/6840cf2ea812bbbcec29660d7484184346e0887d"><code>6840cf2</code></a>
<a href="https://github.com/npm/template-oss/pull/487">#487</a>
bump <code>[email protected]</code></li>
<li><a
href="https://github.com/npm/template-oss/commit/552c637f699dc7ad8f8c3e5b74882bbbc4b7ec93"><code>552c637</code></a>
<a href="https://github.com/npm/template-oss/pull/487">#487</a>
bump <code>[email protected]</code></li>
<li><a
href="https://github.com/npm/template-oss/commit/c6fd5564c61694d1d60524fd548cc69ed70c6635"><code>c6fd556</code></a>
<a href="https://github.com/npm/template-oss/pull/487">#487</a>
bump <code>[email protected]</code></li>
<li><a
href="https://github.com/npm/template-oss/commit/4a3fa8e9e15c7c78c7740b2481dc33bee09669fc"><code>4a3fa8e</code></a>
<a href="https://github.com/npm/template-oss/pull/487">#487</a>
bump <code>@npmcli/[email protected]</code></li>
<li><a
href="https://github.com/npm/template-oss/commit/5ddf2094bad15c19c41e514851e3f354c0204b6d"><code>5ddf209</code></a>
<a href="https://github.com/npm/template-oss/pull/487">#487</a>
bump <code>@npmcli/[email protected]</code></li>
<li><a
href="https://github.com/npm/template-oss/commit/6ff9e171b722844fb933622eb43d4a9e3bd3ef22"><code>6ff9e17</code></a>
<a href="https://github.com/npm/template-oss/pull/487">#487</a>
bump <code>@npmcli/[email protected]</code></li>
<li><a
href="https://github.com/npm/template-oss/commit/e815f956cd66c133afeb6bd8119b05b984435651"><code>e815f95</code></a>
<a href="https://github.com/npm/template-oss/pull/482">#482</a>
bump release-please from 16.12.0 to 16.13.0 (<a
href="https://github.com/npm/template-oss/issues/482">#482</a>)
(<a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot])</li>
<li><a
href="https://github.com/npm/template-oss/commit/3528a02b307bc56fe9bcdf813b7c51769287a0b8"><code>3528a02</code></a>
<a href="https://github.com/npm/template-oss/pull/474">#474</a>
bump diff from 5.2.0 to 6.0.0 (<a
href="https://github.com/npm/template-oss/issues/474">#474</a>)
(<a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot])</li>
</ul>
<h3>Chores</h3>
<ul>
<li><a
href="https://github.com/npm/template-oss/commit/eb549a4d112f370db7557a4e30446d4a90c57db3"><code>eb549a4</code></a>
<a href="https://github.com/npm/template-oss/pull/473">#473</a>
bump <code>@​npmcli/eslint-config</code> from 4.0.5 to 5.0.0 (<a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot])</li>
</ul>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/npm/template-oss/blob/main/CHANGELOG.md"><code>@​npmcli/template-oss</code>'s
changelog</a>.</em></p>
<blockquote>
<h2><a
href="https://github.com/npm/template-oss/compare/v4.23.3...v4.23.4">4.23.4</a>
(2024-10-02)</h2>
<h3>Dependencies</h3>
<ul>
<li><a
href="https://github.com/npm/template-oss/commit/d267eb37f516cace03d8d30fbaf20a91d8525005"><code>d267eb3</code></a>
<a href="https://github.com/npm/template-oss/pull/487">#487</a>
bump <code>[email protected]</code></li>
<li><a
href="https://github.com/npm/template-oss/commit/1d3b53e5a0a35dbf15303f2d19008e0e23c431b3"><code>1d3b53e</code></a>
<a href="https://github.com/npm/template-oss/pull/487">#487</a>
bump <code>[email protected]</code></li>
<li><a
href="https://github.com/npm/template-oss/commit/6840cf2ea812bbbcec29660d7484184346e0887d"><code>6840cf2</code></a>
<a href="https://github.com/npm/template-oss/pull/487">#487</a>
bump <code>[email protected]</code></li>
<li><a
href="https://github.com/npm/template-oss/commit/552c637f699dc7ad8f8c3e5b74882bbbc4b7ec93"><code>552c637</code></a>
<a href="https://github.com/npm/template-oss/pull/487">#487</a>
bump <code>[email protected]</code></li>
<li><a
href="https://github.com/npm/template-oss/commit/c6fd5564c61694d1d60524fd548cc69ed70c6635"><code>c6fd556</code></a>
<a href="https://github.com/npm/template-oss/pull/487">#487</a>
bump <code>[email protected]</code></li>
<li><a
href="https://github.com/npm/template-oss/commit/4a3fa8e9e15c7c78c7740b2481dc33bee09669fc"><code>4a3fa8e</code></a>
<a href="https://github.com/npm/template-oss/pull/487">#487</a>
bump <code>@npmcli/[email protected]</code></li>
<li><a
href="https://github.com/npm/template-oss/commit/5ddf2094bad15c19c41e514851e3f354c0204b6d"><code>5ddf209</code></a>
<a href="https://github.com/npm/template-oss/pull/487">#487</a>
bump <code>@npmcli/[email protected]</code></li>
<li><a
href="https://github.com/npm/template-oss/commit/6ff9e171b722844fb933622eb43d4a9e3bd3ef22"><code>6ff9e17</code></a>
<a href="https://github.com/npm/template-oss/pull/487">#487</a>
bump <code>@npmcli/[email protected]</code></li>
<li><a
href="https://github.com/npm/template-oss/commit/e815f956cd66c133afeb6bd8119b05b984435651"><code>e815f95</code></a>
<a href="https://github.com/npm/template-oss/pull/482">#482</a>
bump release-please from 16.12.0 to 16.13.0 (<a
href="https://github.com/npm/template-oss/issues/482">#482</a>)
(<a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot])</li>
<li><a
href="https://github.com/npm/template-oss/commit/3528a02b307bc56fe9bcdf813b7c51769287a0b8"><code>3528a02</code></a>
<a href="https://github.com/npm/template-oss/pull/474">#474</a>
bump diff from 5.2.0 to 6.0.0 (<a
href="https://github.com/npm/template-oss/issues/474">#474</a>)
(<a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot])</li>
</ul>
<h3>Chores</h3>
<ul>
<li><a
href="https://github.com/npm/template-oss/commit/eb549a4d112f370db7557a4e30446d4a90c57db3"><code>eb549a4</code></a>
<a href="https://github.com/npm/template-oss/pull/473">#473</a>
bump <code>@​npmcli/eslint-config</code> from 4.0.5 to 5.0.0 (<a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot])</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/npm/template-oss/commit/deb5d5f681f3e88fa234f1827e7ff613d4deacc0"><code>deb5d5f</code></a>
chore: release 4.23.4 (<a
href="https://github.com/npm/template-oss/issues/475">#475</a>)</li>
<li><a
href="https://github.com/npm/template-oss/commit/d267eb37f516cace03d8d30fbaf20a91d8525005"><code>d267eb3</code></a>
deps: bump [email protected]</li>
<li><a
href="https://github.com/npm/template-oss/commit/1d3b53e5a0a35dbf15303f2d19008e0e23c431b3"><code>1d3b53e</code></a>
deps: bump [email protected]</li>
<li><a
href="https://github.com/npm/template-oss/commit/6840cf2ea812bbbcec29660d7484184346e0887d"><code>6840cf2</code></a>
deps: bump [email protected]</li>
<li><a
href="https://github.com/npm/template-oss/commit/552c637f699dc7ad8f8c3e5b74882bbbc4b7ec93"><code>552c637</code></a>
deps: bump [email protected]</li>
<li><a
href="https://github.com/npm/template-oss/commit/c6fd5564c61694d1d60524fd548cc69ed70c6635"><code>c6fd556</code></a>
deps: bump [email protected]</li>
<li><a
href="https://github.com/npm/template-oss/commit/4a3fa8e9e15c7c78c7740b2481dc33bee09669fc"><code>4a3fa8e</code></a>
deps: bump <code>@​npmcli/package-json</code><a
href="https://github.com/6"><code>@​6</code></a>.0.0</li>
<li><a
href="https://github.com/npm/template-oss/commit/5ddf2094bad15c19c41e514851e3f354c0204b6d"><code>5ddf209</code></a>
deps: bump <code>@​npmcli/map-workspaces</code><a
href="https://github.com/4"><code>@​4</code></a>.0.0</li>
<li><a
href="https://github.com/npm/template-oss/commit/6ff9e171b722844fb933622eb43d4a9e3bd3ef22"><code>6ff9e17</code></a>
deps: bump <code>@​npmcli/git</code><a
href="https://github.com/6"><code>@​6</code></a>.0.0</li>
<li><a
href="https://github.com/npm/template-oss/commit/e815f956cd66c133afeb6bd8119b05b984435651"><code>e815f95</code></a>
deps: bump release-please from 16.12.0 to 16.13.0 (<a
href="https://github.com/npm/template-oss/issues/482">#482</a>)</li>
<li>Additional commits viewable in <a
href="https://github.com/npm/template-oss/compare/v4.23.3...v4.23.4">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=@npmcli/template-oss&package-manager=npm_and_yarn&previous-version=4.23.3&new-version=4.23.4)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: npm CLI robot <[email protected]>
    @dependabot @npm-cli-bot
    dependabot[bot] and npm-cli-bot authored Nov 21, 2024
    Configuration menu
    Copy the full SHA
    fca8f29 View commit details
    Browse the repository at this point in the history

  3. chore: release 7.1.1 (#123) 

    🤖 I have created a release *beep* *boop*
---


##
[7.1.1](v7.1.0...v7.1.1)
(2024-11-21)
### Bug Fixes
*
[`acf64a7`](acf64a7)
[#120](#120) cache local
environment values (#120) (@Tofandel)
### Chores
*
[`fca8f29`](fca8f29)
[#119](#119) bump
@npmcli/template-oss from 4.23.3 to 4.23.4 (#119) (@dependabot[bot],
@npm-cli-bot)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
    @github-actions
    github-actions[bot] authored Nov 21, 2024
    Configuration menu
    Copy the full SHA
    e8631b4 View commit details
    Browse the repository at this point in the history
Loading