feat: support libc field checks #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlf
force-pushed
the
nlf/libc-support
branch
2 times, most recently
from
81bccbb to
623dace
Compare
wraithgar
reviewed
Mar 20, 2023
wraithgar
approved these changes
Mar 21, 2023
Merged
wraithgar
pushed a commit
to npm/documentation
that referenced
this pull request
Sep 3, 2024
This has been implemented in npm/npm-install-checks#54, but it seems to have never been documented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this implements support for matching the
libcfield as part ofcheckPlatformfollow up: after this lands we'll want to update the error messaging for the
EBADPLATFORMerror code in the cli to account for the new fieldsfor npm/rfcs#438